Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1013 - "knowledge images" don't crash anymore with null width and height #1131

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • knowledge_panel_element_card.dart: null width and height are tolerated

For the record beers are not strong enough for that bug; whiskey is.

Screenshot

Simulator Screen Shot - iPhone 8 Plus - 2022-02-12 at 14 45 13

…th `null` with and height

Impacted file:
* `knowledge_panel_element_card.dart`: `null` width and height are tolerated
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner February 12, 2022 13:46
@monsieurtanuki monsieurtanuki linked an issue Feb 12, 2022 that may be closed by this pull request
@monsieurtanuki monsieurtanuki merged commit 4dcb9f5 into openfoodfacts:develop Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image not rendered in the alcohol panel
3 participants