Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for openfoodfacts.dev (and possibly totally custom like localhost/) in Dev Settings #1145

Closed
teolemon opened this issue Feb 16, 2022 · 2 comments
Closed

Add support for openfoodfacts.dev (and possibly totally custom like localhost/) in Dev Settings #1145

teolemon opened this issue Feb 16, 2022 · 2 comments
Assignees
@monsieurtanuki
Labels
dev mode

Comments

@teolemon
Copy link
Member

What

  • Add support for openfoodfacts.dev (and possibly totally custom like localhost/) in Dev Settings
  • Unsure if the change needs to happen in openfoodfacts-dart or here

Part of
@M123-dev
Copy link
Member

M123-dev commented Feb 20, 2022 •
edited
Loading

We already have support for changing in off-dart and we can switch between .org and .net in the dev settings, so just this is just a little enhancement

@monsieurtanuki monsieurtanuki self-assigned this Mar 13, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Mar 13, 2022
@monsieurtanuki
feat: openfoodfacts#1145 - added a preference for "test env host"
f36b306 
Impacted files:
* `product_query.dart`: improved method `setQueryType` in order to include the new "test env host" preference
* `user_preferences.dart`: added getter/setter for `String` in dev mode
* `user_preferences_dev_mode.dart`: added a dialog for "test env host"
@monsieurtanuki monsieurtanuki mentioned this issue Mar 13, 2022
Merged
monsieurtanuki added a commit that referenced this issue Mar 13, 2022
@monsieurtanuki
feat: #1145 - added a preference for "test env host" (#1204)
b16d050 
Impacted files:
* `product_query.dart`: improved method `setQueryType` in order to include the new "test env host" preference
* `user_preferences.dart`: added getter/setter for `String` in dev mode
* `user_preferences_dev_mode.dart`: added a dialog for "test env host"
@monsieurtanuki
Copy link
Contributor

Done in #1204.
Please create a new issue if you want the http/https to be a preference too.

@github-actions github-actions bot mentioned this issue Mar 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
dev mode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @monsieurtanuki @M123-dev