Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History tab compare: show deactivated "Compare 0 products" instead of nothing #1173

Closed
Tracked by #1171
M123-dev opened this issue Mar 3, 2022 · 5 comments
Closed
Tracked by #1171

History tab compare: show deactivated "Compare 0 products" instead of nothing #1173

M123-dev opened this issue Mar 3, 2022 · 5 comments
Labels
compare mode good first issue Good for newcomers history

Comments

@M123-dev
Copy link
Member

M123-dev commented Mar 3, 2022 •
edited by teolemon
Loading

What

  • History tab compare: show deactivated "Compare 0 products" instead of nothing
@M123-dev M123-dev mentioned this issue Mar 3, 2022
Closed
12 tasks
@teolemon teolemon changed the title History tab compare, show deactivated "Compare 0 products" instead of nothing History tab compare: show deactivated "Compare 0 products" instead of nothing Mar 6, 2022
@teolemon teolemon changed the title History tab compare: show deactivated "Compare 0 products" instead of nothing History tab compare: show deactivated "Compare 0 products" instead of nothing. Mar 6, 2022
@teolemon teolemon changed the title History tab compare: show deactivated "Compare 0 products" instead of nothing. History tab compare: show deactivated "Compare 0 products" instead of nothing Mar 6, 2022
@sgayangi
Copy link
Contributor

Hi, just wondering if this is an acceptable solution for this issue?

Screenshot_20220311-215928

@M123-dev
Copy link
Member Author

Yes @sgayangi, I was thinking of exactly that. Now we can think about if it makes sense to let the button be deactivated for just one product but I don't have a strong opinion on that

@sgayangi
Copy link
Contributor

It does make sense for the button to be deactivated for just a single product as well. Shall I do the necessary changes to do so?

@M123-dev
Copy link
Member Author

If you like @sgayangi

@sgayangi sgayangi mentioned this issue Mar 12, 2022
Merged
@teolemon
Copy link
Member

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compare mode good first issue Good for newcomers history
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @M123-dev @sgayangi