Compare button enabled only for two or more products #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M123-dev
approved these changes
Mar 12, 2022
| builder: (BuildContext context) => | ||
| PersonalizedRankingPage.fromItems( | ||
| products: list, | ||
| title: 'Your ranking', |
There was a problem hiding this comment.
I know this part isn't from you but it'd be good if you could add a todo comment
// TODO(X): Translate
There was a problem hiding this comment.
May I know, does translation mean adding the strings to the .arb file? In which case, I can do so for this and other raw strings in the code.
There was a problem hiding this comment.
Thanks for adding
Yes, translating is just adding it to app_en.arb file, the rest is dealt with automatically, we just have to add usefull comments for the translators, so that they know what is meant by "Your ranking" or other Strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Part of
(please be as granular as possible)