Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Search) The Return and Filter buttons are not longer visible after we started scrolling #1292

Closed
teolemon opened this issue Mar 22, 2022 · 8 comments · Fixed by #1339
Closed

(Search) The Return and Filter buttons are not longer visible after we started scrolling #1292

teolemon opened this issue Mar 22, 2022 · 8 comments · Fixed by #1339
Labels
personal search

Comments

@teolemon
Copy link
Member

What

  • (Search) The Return and Filter buttons are not longer visible after we started scrolling
  • In addition, they are partly hidden by the top bar

Screenshot

image
@vik4114
Copy link
Contributor

vik4114 commented Mar 22, 2022

@teolemon Should we make them into appbar?

@vik4114 vik4114 mentioned this issue Mar 22, 2022
Closed
@M123-dev
Copy link
Member

@vik4114 what about a SilverAppBar where they normally stay the same but move into a app Bar when scrolling down

@vik4114
Copy link
Contributor

vik4114 commented Mar 23, 2022

@M123-dev what do you think?

sr.mp4

@M123-dev
Copy link
Member

The color somehow destroys the feeling of the colored background. You should be able to make the app bar transparent though. And don't forget to set it's elevation to 0 to hide it's shadows

@vik4114
Copy link
Contributor

vik4114 commented Mar 24, 2022 •
edited
Loading

@M123-dev This is how it looks in transparent

1.mp4
2.mp4

@M123-dev
Copy link
Member

Heyy looks good @vik4114 thanks for making it transparent. But now looking at it again it's not so good to read with the cards behind the title. What about making the AppBar background color the same as the Scaffold color. So that it doesn't stand out but it's readable.

vik4114 added a commit to vik4114/smooth-app that referenced this issue Mar 26, 2022
@vik4114
Merge branch 'develop' into issue-openfoodfacts#1292
cf044df
@vik4114
Copy link
Contributor

vik4114 commented Mar 26, 2022

@M123-dev Now it is transparent when expanded and scaffold color when collapsed

3.mp4

@M123-dev
Copy link
Member

Looks great @vik4114

@vik4114 vik4114 mentioned this issue Mar 26, 2022
Merged
M123-dev pushed a commit that referenced this issue Mar 26, 2022
@vik4114
fix: #1292 Changed Appbar into Sliver appbar (#1339)
5ca9607 
* intial commit

* Changed appbar into sliverbarr

* Removed filter from empty screen

* Removed unused controller
@github-actions github-actions bot mentioned this issue Mar 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
personal search
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #1292 Changed Appbar into Sliver appbar vik4114/smooth-app
3 participants
@teolemon @M123-dev @vik4114