Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The iOS release is currently broken #1300

Closed
teolemon opened this issue Mar 22, 2022 · 10 comments · Fixed by #1650 or #2666
Closed

The iOS release is currently broken #1300

teolemon opened this issue Mar 22, 2022 · 10 comments · Fixed by #1650 or #2666
Labels
🐛 bug Something isn't working CI 🍎 cocoapods 🍎 iOS iOS specific issues or PRs 🎯 P0
Milestone

Comments

@teolemon
Copy link
Member

What

@teolemon teolemon added 🐛 bug Something isn't working CI 🍎 iOS iOS specific issues or PRs labels Mar 22, 2022
@teolemon
Copy link
Member Author

It seems to be Cocoapods and Sentry all over again. It would be nice to have a system to prevent this to happen at all deps updates.
[!] CocoaPods could not find compatible versions for pod "Sentry":
In snapshot (Podfile.lock):
Sentry (= 7.9.0, ~> 7.9.0)

  In Podfile:
    sentry_flutter (from `.symlinks/plugins/sentry_flutter/ios`) was resolved to 0.0.1, which depends on
      Sentry (~> 7.10.1)

@M123-dev
Copy link
Member

It would be nice to have a system to prevent this to happen at all deps updates.

Any idea on how to do it, also does it work when recreating the podfile.lock

@monsieurtanuki
Copy link
Contributor

@M123-dev My suggestion: put a comment on the "sentry_flutter: ^6.4.0" line, like the one I put there:

path: ^1.8.0 # careful with 1.8.1 because of https://github.com/flutter/flutter/issues/95478

That would prevent helpful Android users from upgrading dangerous packages even when it looks harmless to do so.

@M123-dev
Copy link
Member

Can anyone on MacOS run:

pod update
pod install

getsentry/sentry-dart#746 (comment)

@teolemon
Copy link
Member Author

The CI uses macOS @monsieurtanuki, so we could insert it within, or even have a specific workflow triggered by anychange to pubspec.yaml, and that would open a branch with any changes generated by those 2 commands ?

@monsieurtanuki
Copy link
Contributor

@teolemon Honestly I don't know anything about those "new" compilation tools.

That said, if you're sure that the solution would be to call those 2 lines, you could integrate them to the process systematically: that would be a pointless step for Android but who cares?

I've just run those 2 commands:

pod update # 5 minutes
pod install # 10 seconds
pod update # 20 seconds
pod install # 10 seconds

That means that once the big update is done, running the commands again takes less than a minute.

But there were probably interesting messages that we would have dismissed with the automation:

CocoaPods 1.11.3 is available.
To update use: sudo gem install cocoapods

and

[!] CocoaPods did not set the base configuration of your project because your project already has a custom config set. In order for CocoaPods integration to work at all, please either set the base configurations of the target Runner to Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig or include the Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig in your build configuration (Flutter/Release.xcconfig).

@M123-dev
Copy link
Member

That said, if you're sure that the solution would be to call those 2 lines

Definitely no, all my knowledge on CocoaPods and iOS specific errors consist purely of other people's reports on the internet.

@monsieurtanuki
Copy link
Contributor

In my case, as suggested by the iOS logs, I had to run pod update Sentry and then I could flutter run.

@M123-dev
Copy link
Member

Needs to be also added to ios-release-to-org-openfoodfacts-scanner.yml

@teolemon
Copy link
Member Author

@teolemon teolemon linked a pull request Jul 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working CI 🍎 cocoapods 🍎 iOS iOS specific issues or PRs 🎯 P0
3 participants