Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pod update Sentry #2666

Merged
merged 3 commits into from
Jul 28, 2022
Merged

ci: pod update Sentry #2666

merged 3 commits into from
Jul 28, 2022

Conversation

teolemon
Copy link
Member

What

ci: pod update Sentry

ci: pod update Sentry
@@ -74,7 +75,7 @@ jobs:
VERSION_NAME: ${{ env.RELEASE_VERSION }}

- name: Build app
run: cd ./packages/smooth_app && flutter build ios --release --no-codesign
run: cd ./packages/smooth_app && pod update Sentry && flutter build ios --release --no-codesign
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably ios/pod instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure what you mean

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean pod must be run from the ios subfolder.

@codecov-commenter
Copy link

Codecov Report

Merging #2666 (0ae23de) into develop (2ea0da3) will decrease coverage by 1.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2666      +/-   ##
==========================================
- Coverage     8.86%   7.25%   -1.61%     
==========================================
  Files          161     219      +58     
  Lines         6623   10530    +3907     
==========================================
+ Hits           587     764     +177     
- Misses        6036    9766    +3730     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 60.00% <0.00%> (-22.98%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 21.68% <0.00%> (-9.75%) ⬇️
packages/smooth_app/lib/main.dart 14.65% <0.00%> (-3.24%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
...ackages/smooth_app/lib/pages/scan/scan_header.dart 3.33% <0.00%> (-1.43%) ⬇️
... and 236 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@teolemon teolemon marked this pull request as ready for review July 28, 2022 17:40
@teolemon teolemon requested a review from a team as a code owner July 28, 2022 17:40
@teolemon teolemon merged commit 1304d5c into develop Jul 28, 2022
@teolemon teolemon deleted the pod-update-Sentry branch July 28, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

CocoaPods could not find compatible versions for pod "Sentry" The iOS release is currently broken
3 participants