Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ingredient photo should be fully visible in the ingredient extraction screen. #1376

Closed
Tracked by #107
teolemon opened this issue Mar 28, 2022 · 4 comments
Closed
Tracked by #107

The ingredient photo should be fully visible in the ingredient extraction screen. #1376

teolemon opened this issue Mar 28, 2022 · 4 comments
Assignees
@cli1005
Labels
✏️ Editing - ingredients ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎨 Mockup required

Comments

@teolemon
Copy link
Member

What

  • The ingredient photo should be fully visible in the ingredient extraction screen.

Steps to reproduce the behavior

  1. Go to Dev Mode
  2. Enable ingredient extraction button
  3. Tap on the ingredient extraction button and take a new photo
  4. See very zoomed ingredient photo

Expected behavior

Fully visible ingredient photo, potentially zoomable

Why

  • To ensure people can double check for extraction errors

Part of

Screenshot/Mockup/Before-After

image
@teolemon teolemon added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✏️ Editing - ingredients labels Mar 28, 2022
@teolemon teolemon mentioned this issue Mar 28, 2022
Closed
8 tasks
@M123-dev
Copy link
Member

We could use the same widget as for the images on the product page

@teolemon
Copy link
Member Author

The product page widget does not work well for ingredients (you have to scroll a lot).

@cli1005 cli1005 moved this from To discuss and validate to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 8, 2022
@cli1005
Copy link
Contributor

cli1005 commented Apr 8, 2022

What about the widget InteractiveViewer? I will prepare the PR if the following result is ok for you

rpreplay-final1649429066_453DauNy.mp4

cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 8, 2022
@cli1005
fix: openfoodfacts#1376 - fit/zoom ingredient extraction photo
f1c0ebc
@M123-dev
Copy link
Member

M123-dev commented Apr 8, 2022

Looks good @cli1005

@cli1005 cli1005 mentioned this issue Apr 8, 2022
Merged
@cli1005 cli1005 moved this from In Progress to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 8, 2022
@VaiTon VaiTon closed this as completed in 9eb925e Apr 9, 2022
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 9, 2022
@github-actions github-actions bot mentioned this issue Apr 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cli1005 cli1005

Labels
✏️ Editing - ingredients ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎨 Mockup required
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @M123-dev @cli1005