Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Product Addition) The newly added product should be immediately visible once you exit product addition #1395

Closed
1 task
Tracked by #1379
teolemon opened this issue Mar 29, 2022 · 1 comment · Fixed by #1520
Closed
1 task
Tracked by #1379

(Product Addition) The newly added product should be immediately visible once you exit product addition #1395

teolemon opened this issue Mar 29, 2022 · 1 comment · Fixed by #1520
Assignees
@cli1005
Labels
🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Mar 29, 2022 •
edited
Loading

What

  • The newly added product should be immediately visible once you exit product addition

Part of

Screenshot
@teolemon teolemon mentioned this issue Mar 29, 2022
Open
@teolemon teolemon added the Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. label Mar 29, 2022
@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
@stephanegigandet stephanegigandet moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 4, 2022
@cli1005 cli1005 self-assigned this Apr 4, 2022
@cli1005 cli1005 moved this from Todo (ready 2 dev) to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 6, 2022
@cli1005
Copy link
Contributor

cli1005 commented Apr 8, 2022 •
edited by VaiTon
Loading

This will be a long comment 😅

Actual situation:

  • Product is added once the first photo is uploaded successfully by calling the API : OpenFoodAPIClient.addProductImage, which might be meaningful to gather more product as possible.
  • Once the first photo has been uploaded, we can use both BACK button(<) and FINISH button back to scan page ⚠️
  • If the scanned code is not valid, uploading photo process failed with a vague message: An error occurred ❓
  • The newly added product does not appear in carousel 🚫

Solution proposed

  • If one photo has been uploaded successfully (the product has been added)
    • the BACK button(<) will be removed from Appbar, user returns to the scan page by clicking FINISH button
    • The newly added product appears in carousel
  • If uploading photo process failed (the product has not been added)
    • we can use both BACK button(<) and FINISH button back to scan page
    • The newly added product does not appear in carousel, neither the Product NotFound card

If you are ok for the solution proposed, please let me know, a PR is ready

cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 8, 2022
@cli1005
fix: openfoodfacts#1395 - show newly added product in carousel
c47ebd2
@cli1005 cli1005 mentioned this issue Apr 8, 2022
Merged
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 8, 2022
@cli1005
fix: openfoodfacts#1395 - refactoring unused import
238da17
@cli1005 cli1005 moved this from In Progress to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 8, 2022
@teolemon teolemon linked a pull request Apr 9, 2022 that will close this issue
fix: #1395 - show newly added product in carousel #1520
Merged
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 11, 2022
@cli1005
fix: openfoodfacts#1395 - refactoring make variable private
52ac3c7
cli1005 added a commit that referenced this issue Apr 11, 2022
@cli1005
fix: #1395 - show newly added product in carousel (#1520)
536528d 
* fix: #1395 - show newly added product in carousel

* fix: #1395 - refactoring unused import

* fix: #1395 - refactoring make variable private
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 11, 2022
@github-actions github-actions bot mentioned this issue Apr 11, 2022
Closed
cli1005 added a commit that referenced this issue Apr 21, 2022
@cli1005 @teolemon
fix: #1352 - robotoff insight card shows permanently (#1574)
f671807 
* fix: #1395 - show newly added product in carousel

* fix: #1395 - refactoring unused import

* fix: #1395 - refactoring make variable private

* fix: #1352 - robotoff card shows permanently

* fix: #1352 - codereview refactoring

* fix: #1352 - check fix

* fix: #1352 - pretest check fix

* fix: #1352 - codereview fix

Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cli1005 cli1005

Labels
🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: #1395 - show newly added product in carousel cli1005/smooth-app
2 participants
@teolemon @cli1005