Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to track active Tab in Dark Mode #1424

Closed
abhay1821 opened this issue Mar 31, 2022 · 4 comments · Fixed by #1430
Closed

Bug: Unable to track active Tab in Dark Mode #1424

abhay1821 opened this issue Mar 31, 2022 · 4 comments · Fixed by #1430
Assignees
Labels
darkmode Ensuring we look good in the dark
Milestone

Comments

@abhay1821
Copy link
Contributor

What

  • As we can track the active tab with white color it's difficult to track the same in Dark mode as both Active and Inactive tab Icons remains the same (White Color).

Steps to reproduce the behavior

  1. Switch to dark Mode / System Default Is DarkMode
  2. Bottom Navigation Tab

Why

  • As a user it should be a differentiable, Tab that is currently active in Dark Mode too as we can keep track in Light Mode

Part of

Screenshot/Mockup/Before-After

dark.mov

Smartphone model

  • Device: [ Note 7 PRO]
  • OS: [e.g. Android 10]
  • App Version [0.0.0+1]
@abhay1821
Copy link
Contributor Author

abhay1821 commented Mar 31, 2022

Hi, @teolemon @M123-dev
Can have Your Suggestion on it before moving forward. As if now we do have a hardcoded Color for the active Tab i.e White

@teolemon teolemon added the darkmode Ensuring we look good in the dark label Mar 31, 2022
@teolemon
Copy link
Member

probably deharcoding, and choosing a color for both light and dark mode, I guess ? @M123-dev ?

@bhattabhi013
Copy link
Contributor

Hi @abhay1821 ,
Try to use the primary color from the color scheme.

@abhay1821
Copy link
Contributor Author

@teolemon could please assign this to me. I will work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
darkmode Ensuring we look good in the dark
Development

Successfully merging a pull request may close this issue.

3 participants