Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DarkMode Icon track fixed #1430

Merged
merged 1 commit into from
Mar 31, 2022
Merged

fix: DarkMode Icon track fixed #1430

merged 1 commit into from
Mar 31, 2022
+1 −0

Conversation

abhay1821
Copy link
Contributor

What

  • This PR includes the fix of the Dark Mode NavigationTab Icon track

ScreenRecording

dark.mov

Fixes bug(s)

Part of

@abhay1821 abhay1821 requested a review from a team as a code owner March 31, 2022 17:09
@teolemon teolemon added navigation darkmode Ensuring we look good in the dark labels Mar 31, 2022
@abhay1821
Copy link
Contributor Author

Hi @M123-dev,
Could please review it and suggest changes if required

@teolemon teolemon linked an issue Mar 31, 2022 that may be closed by this pull request
Bug: Unable to track active Tab in Dark Mode #1424
Closed
@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
M123-dev
M123-dev approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@M123-dev M123-dev merged commit fbecbcb into openfoodfacts:develop Mar 31, 2022
@github-actions github-actions bot mentioned this pull request Mar 31, 2022
Closed
@abhay1821 abhay1821 deleted the darkModeIcon branch March 31, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees

@abhay1821 abhay1821

Labels
darkmode Ensuring we look good in the dark navigation
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging this pull request may close these issues.

Bug: Unable to track active Tab in Dark Mode
3 participants
@abhay1821 @M123-dev @teolemon