-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Text on the scanner should not be selectable #1434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyyy, some minor comments:
What about instead of using a conditional Text()
or Text().selectable()
everywhere just updating the Selectable Text extension for allowing to pass a bool if selectable or not and then deciding there wether to return Text or SelectableText
extension Selectable on Text {
Widget selectable({bool isSelectable = false}) {
return isSelectable
? SelectableText( ... )
: Text( ... )
Also noticed the quantity text in the product title card is still always selectable
Codecov Report
@@ Coverage Diff @@
## develop #1434 +/- ##
=========================================
Coverage ? 9.15%
=========================================
Files ? 158
Lines ? 6380
Branches ? 0
=========================================
Hits ? 584
Misses ? 5796
Partials ? 0 Continue to review full report at Codecov.
|
Thanks for the review and for providing a better approach to the solution. I've made the changes in the selectable extension. |
selectAll: true, | ||
), | ||
) | ||
: Text(data!); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style is missing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @bhattabhi013
What
Text on the scanner should not be selectable
Screenshot
Record_2022-03-31-23-45-21_cc729dbb1ea2c751a543590b5da9708c.mp4
Fixes bug(s)
Part of
(please be as granular as possible)