Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding: Some texts are selectable and shouldn't be. #1455

Closed
g123k opened this issue Apr 2, 2022 · 7 comments · Fixed by #1874
Closed

Onboarding: Some texts are selectable and shouldn't be. #1455

g123k opened this issue Apr 2, 2022 · 7 comments · Fixed by #1874
Assignees
@cli1005
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎯 P1 🎨 UI / UX
Milestone
V1

Comments

@g123k
Copy link
Collaborator

g123k commented Apr 2, 2022

What

Some texts are selectable and shouldn't be.

Steps to reproduce the behavior

  1. Open the onboarding to the Nutrition facts info:

Screen Shot 2022-04-02 at 12 32 39

Expected behavior

100g & compared to… shouldn't be selectable
@g123k g123k added 🎨 UI / UX 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… labels Apr 2, 2022
@abhay1821
Copy link
Contributor

Hi @g123k,
Could please assign this to me I will fix it.

@bhattabhi013
Copy link
Contributor

Hi @abhay1821,
If you don't mind can I work on this? I already had a discussion with @M123-dev and solved the same type of issue in #1434 .

@abhay1821
Copy link
Contributor

Ahh.. @bhattabhi013 saw your comment just now So I am almost done with the soln. Well no worries, You made the changes on the extension file which I had implemented earlier, for the selectable Text issue. and this Issue is somewhat different from that. The data which here we are fetching through an HTML widget So I have made changes for that. However If I face any issue then surely I will reach out.

@bhattabhi013
Copy link
Contributor

No issues @abhay1821, feel free to reach out in case an issue is faced.

@abhay1821
Copy link
Contributor

abhay1821 commented Apr 3, 2022 •
edited
Loading

Hi @g123k,
Quick update if the HTMLwidget text you mentioned is to be not selectable then I fear we will not be able to select its details too. So if you are fine with then should I proceed?

@teolemon teolemon changed the title Onboarding: some texts are selectable Onboarding: Some texts are selectable and shouldn't be. Apr 22, 2022
@abhay1821 abhay1821 removed their assignment Apr 23, 2022
@teolemon teolemon added this to the V1 milestone May 4, 2022
@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 16, 2022
@cli1005
Copy link
Contributor

cli1005 commented May 16, 2022

One little, silly maybe 😄 question, Why we should make these texts no selectable?

@cli1005 cli1005 moved this from Todo (ready 2 dev) to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 16, 2022
@teolemon
Copy link
Member

We noticed regression in tapability when we made them selectable.

@cli1005 cli1005 moved this from In Progress to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 17, 2022
@cli1005 cli1005 moved this from Pull Requests to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 17, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue May 17, 2022
@cli1005
fix: openfoodfacts#1455 - make tappable header no selectable
45b7f27
@cli1005 cli1005 mentioned this issue May 17, 2022
Merged
@cli1005 cli1005 moved this from In Progress to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 17, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue May 18, 2022
@cli1005
fix: openfoodfacts#1455 -refactoring
4003329
cli1005 added a commit that referenced this issue May 18, 2022
@cli1005
fix: #1455 - make tappable header no selectable (#1874)
6f7fa9a 
* fix: #1455 - make tappable header no selectable

* fix: #1455 -refactoring
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cli1005 cli1005

Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎯 P1 🎨 UI / UX
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: #1455 - make tappable header no selectable cli1005/smooth-app
5 participants
@g123k @teolemon @bhattabhi013 @abhay1821 @cli1005