Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1455 - make tappable header no selectable #1874

Merged

Conversation

cli1005
Copy link
Contributor

@cli1005 cli1005 commented May 17, 2022

What

Make tappable header no selectable (Nutrition facts, 100g, Compare to ...)

Screenshot

Simulator Screen Shot - iPhone 13 - 2022-05-17 at 11 18 53

Fixes bug(s)

@cli1005 cli1005 requested a review from a team as a code owner May 17, 2022 09:25
Comment on lines 286 to 287
Widget _buildHtmlCell(
EdgeInsets padding, TextStyle style, bool isSelectable) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Suggested change
Widget _buildHtmlCell(
EdgeInsets padding, TextStyle style, bool isSelectable) {
Widget _buildHtmlCell(
EdgeInsets padding, TextStyle style, { required bool isSelectable}) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M123-dev
Copy link
Member

Just a minor suggestion @cli1005 the rest looks good

@teolemon teolemon added this to the V1 milestone May 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1874 (4003329) into develop (2ea0da3) will decrease coverage by 0.76%.
The diff coverage is 10.23%.

@@            Coverage Diff             @@
##           develop   #1874      +/-   ##
==========================================
- Coverage     8.86%   8.09%   -0.77%     
==========================================
  Files          161     176      +15     
  Lines         6623    7994    +1371     
==========================================
+ Hits           587     647      +60     
- Misses        6036    7347    +1311     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...th_app/lib/cards/data_cards/image_upload_card.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/cards/data_cards/score_card.dart 4.54% <0.00%> (-0.22%) ⬇️
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_element_card.dart 0.00% <0.00%> (ø)
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b4933...4003329. Read the comment docs.

@cli1005 cli1005 merged commit 6f7fa9a into openfoodfacts:develop May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding: Some texts are selectable and shouldn't be.
4 participants