fix: trailing Spaces issue Fixed #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @M123-dev, |
Codecov Report
@@ Coverage Diff @@
## develop #1469 +/- ##
==========================================
- Coverage 9.13% 9.04% -0.09%
==========================================
Files 158 158
Lines 6372 6431 +59
==========================================
Hits 582 582
- Misses 5790 5849 +59
Continue to review full report at Codecov.
|
M123-dev
reviewed
Apr 3, 2022
There was a problem hiding this comment.
Looks mostly good just two little improvment ideas:
- You don't need to declare the
emailTrimmedString in a own line. You can directly set it tovalue.trim()e.g.final String emailTrimmed = value.trim(); - Lets just always use
.trim()no need to check first, I don't think that this will cause any bad sideeffects
Also no need to directly ping me after PR creation, a review is automatically requested anyway 👍🏼
|
Sure I will keep it In mind From now. Please Take a look now Just reduced the code as much as possible. |
g123k
added a commit
that referenced
this pull request
Apr 3, 2022
* develop: fix: trailing Spaces issue Fixed (#1469) Update README.md (#1480) feat: dismissible color added to personalized ranking (#1476) fix: no visual feedback on next button (#1460) feat: minor improvement for summary_card (#1474) fix: Translate hardcoded sentences (#1473) fix: Onboarding - Country selected highlighted (#1471) fix: Misaligned Inkwell Fixed (#1459) chore: New Crowdin translations to review and merge (#1450) feat: Support for a "source" within a Knownledge Panel Text element (#1458) # Conflicts: # packages/smooth_app/lib/l10n/app_en.arb # packages/smooth_app/lib/l10n/app_fr.arb
g123k
added a commit
that referenced
this pull request
Apr 3, 2022
* fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
Apr 9, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations * Update app_el.arb * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
Apr 11, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations * Update packages/smooth_app/lib/l10n/app_fr.arb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
Apr 12, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
Apr 15, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
Apr 17, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
Apr 18, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
May 18, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations * Update app_aa.arb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
May 20, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations * Update app_aa.arb * Update packages/smooth_app/lib/l10n/app_es.arb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon
added a commit
that referenced
this pull request
May 22, 2022
* New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * fix: Trigger crowdin refresh (#1483) * fix: knowledge panel name made visible (#1442) * knowledge panel name made visible * used const values on margin * knowledge panel name made visible * fix: Fix food preferences buttons goes into two lines (#1445) * feat: Support for a "source" within a Knownledge Panel Text element (#1458) * Support for source field within a Knowledge Panel text element * Move to a basic Button instead * chore: New Crowdin translations to review and merge (#1450) * New Crowdin translations by Github Action (#677) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * chore: New Crowdin translations * Fix issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> * fix: Misaligned Inkwell Fixed (#1459) * Misaligned Padding Fixed * fix: Onboarding - Country selected highlighted (#1471) * fix: Translate hardcoded sentences (#1473) * Translate hardcoded sentences * Extract all AppLocalizations.of(context) into variables * feat: minor improvement for summary_card (#1474) fix: use theme default style in tabForMore button in summary_card.dart fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart * fix: no visual feedback on next button (#1460) * feat: dismissible color added to personalized ranking (#1476) * dismissible color added to personalized ranking * dismissible color added to personalized ranking * imported direct file rather than relative * made constants in use instead of * Update README.md (#1480) * fix: trailing Spaces issue Fixed (#1469) * trailingSpaces issue Fixed * Changed Approach Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com> * chore: New Crowdin translations * Update app_zu.arb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: M123-dev <marvinmoel05@gmail.com> Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com> Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com> Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com> Co-authored-by: Edouard Marquez <moi@edouard-marquez.me> Co-authored-by: VaiTon <eyadlorenzo@gmail.com> Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com> Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
-This PR includes fix of trailing spaces leading to invalid email or username
Screenshot
fix.mov
Fixes bug(s)
Part of