Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button resized with max line= 1 for change in language bug #1445

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

abhay1821
Copy link
Contributor

What

  • This PR includes fixing of button size of each category with the standard width of the button irrespective of language chosen

Screenshot

Button Resized Same Italian language

Fixes bug(s)

@abhay1821 abhay1821 requested a review from a team as a code owner April 1, 2022 19:00
@abhay1821
Copy link
Contributor Author

Hi @M123-dev,
Could you please review it

@teolemon teolemon linked an issue Apr 1, 2022 that may be closed by this pull request
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@M123-dev M123-dev merged commit 721a49b into openfoodfacts:develop Apr 2, 2022
@abhay1821 abhay1821 deleted the butttonsize branch April 2, 2022 10:32
g123k added a commit that referenced this pull request Apr 3, 2022
* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request Apr 9, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

* Update app_el.arb

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request Apr 11, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

* Update packages/smooth_app/lib/l10n/app_fr.arb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request Apr 12, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request Apr 15, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request Apr 17, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request Apr 18, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request May 18, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

* Update app_aa.arb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request May 20, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

* Update app_aa.arb

* Update packages/smooth_app/lib/l10n/app_es.arb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
teolemon added a commit that referenced this pull request May 22, 2022
* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* fix: Trigger crowdin refresh (#1483)

* fix: knowledge panel name made visible (#1442)

* knowledge panel name made visible

* used const values on margin

* knowledge panel name made visible

* fix: Fix food preferences buttons goes into two lines (#1445)

* feat: Support for a "source" within a Knownledge Panel Text element (#1458)

* Support for source field within a Knowledge Panel text element

* Move to a basic Button instead

* chore: New Crowdin translations to review and merge (#1450)

* New Crowdin translations by Github Action (#677)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* chore: New Crowdin translations

* Fix issues

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>

* fix: Misaligned Inkwell Fixed (#1459)

* Misaligned Padding Fixed

* fix: Onboarding - Country selected highlighted  (#1471)

* fix: Translate hardcoded sentences (#1473)

* Translate hardcoded sentences

* Extract all AppLocalizations.of(context) into variables

* feat: minor improvement for summary_card (#1474)

fix: use theme default style in tabForMore button in summary_card.dart

fix: display a "not implemented" snack bar instead of doing nothing when clicking on "add missing product category" in summary_card.dart

* fix: no visual feedback on next button (#1460)

* feat: dismissible color added to personalized ranking (#1476)

* dismissible color added to personalized ranking

* dismissible color added to personalized ranking

* imported direct file rather than relative

* made constants in use instead of

* Update README.md (#1480)

* fix: trailing Spaces issue Fixed (#1469)

* trailingSpaces issue Fixed

* Changed Approach

Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>

* chore: New Crowdin translations

* Update app_zu.arb

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
Co-authored-by: M123-dev <marvinmoel05@gmail.com>
Co-authored-by: Aman Raj <57723319+AshAman999@users.noreply.github.com>
Co-authored-by: Abhay Chaudhary <chaudharyabhay111@gmail.com>
Co-authored-by: Edouard Marquez <g123k@users.noreply.github.com>
Co-authored-by: Edouard Marquez <moi@edouard-marquez.me>
Co-authored-by: VaiTon <eyadlorenzo@gmail.com>
Co-authored-by: Abhishek Bhatt <47862474+bhattabhi013@users.noreply.github.com>
Co-authored-by: Shimron <60049707+ShimronAlakkal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Food preferences buttons have different size
3 participants