Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual issues on the scan card #1484

Closed
teolemon opened this issue Apr 3, 2022 · 2 comments · Fixed by #1488
Closed

Visual issues on the scan card #1484

teolemon opened this issue Apr 3, 2022 · 2 comments · Fixed by #1488
Labels
scan card
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Apr 3, 2022

What

= The tagline is not legible anymore (grey on grey)
= the bottom prompt is not visible either

Screenshots

image
@AshAman999
Copy link
Member

AshAman999 commented Apr 3, 2022 •
edited
Loading

probably happened on #1474
Just a one-line fix
though I was able to reproduce the bottom part not visible to me the upper screen just worked fine,
Rasing the pr for the same

@AshAman999 AshAman999 mentioned this issue Apr 3, 2022
Merged
@AshAman999
Copy link
Member

Also, I was thinking of this change, it looks good but not sure if the bottom necessarily needs to be of blue color
Maybe something like this would look good, open to suggestions ..
image

@teolemon teolemon linked a pull request Apr 4, 2022 that will close this issue
fix: make card bottom prompt visible #1488
Merged
@teolemon teolemon added this to the V1 milestone Apr 6, 2022
@teolemon teolemon moved this from Todo (ready 2 dev) to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 11, 2022
M123-dev added a commit to AshAman999/smooth-app that referenced this issue Apr 19, 2022
@M123-dev
Merge branch 'develop' into fix-openfoodfacts#1484
bdb13a5
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scan card
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: make card bottom prompt visible AshAman999/smooth-app
2 participants
@teolemon @AshAman999