-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make card bottom prompt visible #1488
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1488 +/- ##
=======================================
Coverage 9.04% 9.04%
=======================================
Files 158 158
Lines 6431 6431
=======================================
Hits 582 582
Misses 5849 5849
Continue to review full report at Codecov.
|
@@ -136,7 +136,9 @@ class _SummaryCardState extends State<SummaryCard> { | |||
child: Center( | |||
child: Text( | |||
AppLocalizations.of(context)!.tab_for_more, | |||
style: Theme.of(context).primaryTextTheme.bodyText1, | |||
style: Theme.of(context).primaryTextTheme.bodyText1?.copyWith( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about .textTheme.bodyText1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VaiTon thought of keeping the blue color so as to make that look like hyperlink to make it obvious that it can be clicked
The button cropped halfway thru is ugly (but the fact that the border is not aware of the content seems a tough problem) |
@teolemon Perhaps adding some alpha would make the transition smoother. |
What about the primary as the background, so that it could be seen as a button |
Actually no button is supposed to be on the card when it is in the scanner, but the same problem occurrences for texts like allergies or ingredients
The thing is, it isn't a button. It's more a hint that the whole card can be tapped or even swiped up |
You're right, but it emphatizes that it can be tapped. I'm for the primary background |
Any progress on this one ? |
The color wasn't finalised, is blue okay for that field? |
@abhay1821 can you look into this issue I'm having troubles with my pc and have sent it for repair, might take 2 - 3 days, |
Fixed some merge conflicts @AshAman999 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge as is, looks good @AshAman999
What
Screenshot
Fixes bug(s)