Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oversized modal, with White on White buttons #1537

Closed
teolemon opened this issue Apr 11, 2022 · 5 comments
Closed

Oversized modal, with White on White buttons #1537

teolemon opened this issue Apr 11, 2022 · 5 comments
Assignees
@monsieurtanuki
Labels
⚙️ Settings

Comments

@teolemon
Copy link
Member

What

  • Oversized modal, with White on White buttons

image
@teolemon teolemon added this to the V2 milestone Apr 11, 2022
@monsieurtanuki
Copy link
Contributor

Here the solution is to use the default smooth dialog (not the "advanced" one).

@monsieurtanuki monsieurtanuki self-assigned this Apr 11, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon Not fantastic, but at least we can have either:

  • solution 1
    Simulator Screen Shot - iPhone 8 Plus - 2022-04-11 at 14 18 03

  • solution 2
    Simulator Screen Shot - iPhone 8 Plus - 2022-04-11 at 14 22 39

@M123-dev
Copy link
Member

We could also combine "Support" with "Connect with us"

@monsieurtanuki
Copy link
Contributor

@M123-dev You mean "Contact us".

For the moment we have

  • support => slack / contact us
  • contact us

We would be better off with:

  • contact us => slack / contact us

@monsieurtanuki
Copy link
Contributor

Used to be:
Capture d’écran 2022-04-11 à 14 35 56

Would be:
Capture d’écran 2022-04-11 à 14 48 56

Simulator Screen Shot - iPhone 8 Plus - 2022-04-11 at 14 49 11

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Apr 11, 2022
@monsieurtanuki
fix: openfoodfacts#1537 - moved the "slack" and "email" contact options
7259cc6 
Impacted files:
* `smooth_main_button.dart`: added a `TODO` about probable deleting of this class.
* `social_handle_view.dart`: moved there "slack" and "email" contact options; refactored
* `user_preferences_settings.dart`: removed the "support" (slack or email) button
@monsieurtanuki monsieurtanuki mentioned this issue Apr 11, 2022
Merged
@github-actions github-actions bot mentioned this issue Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
⚙️ Settings
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @monsieurtanuki @M123-dev