fix: Sign up page: Fix trimmed text not being done correctly #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g123k
changed the title
|
Oops sorry, one file was missing |
M123-dev
approved these changes
Apr 11, 2022
Comment on lines
+151
to
+152
| } else if (_password2Controller.text != | ||
| _password1Controller.text) { |
There was a problem hiding this comment.
Shouldn't both of them be trimedText too
There was a problem hiding this comment.
I was wondering… but the user may want some spaces in its password
… or maybe we should enforce rules on passwords
There was a problem hiding this comment.
I'd definitively sense to not allow spaces in passwords
There was a problem hiding this comment.
I propose to let the code as it, and to open in parallel an issue and discuss about this case (which is not the primary goal of this PR)
There was a problem hiding this comment.
Issue with the password policy: #1555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1542
Rework how TextEditingControllers work on the sign up page