Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1537 - moved the "slack" and "email" contact options #1546

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix: #1537 - moved the "slack" and "email" contact options #1546

merged 1 commit into from
Apr 11, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • smooth_main_button.dart: added a TODO about probable deleting of this class.
  • social_handle_view.dart: moved there "slack" and "email" contact options; refactored
  • user_preferences_settings.dart: removed the "support" (slack or email) button

What

  • there was a "support" button that opened a very tall dialog with "slack" and "email" contact options
  • the dialog was too tall, that's what triggered the issue
  • after comment exchanges, as there's another button called "contact / connect with us", it seemed appropriate to move "slack" and "email" there, which removes the "faulty" tall dialog.

Screenshot

Simulator Screen Shot - iPhone 8 Plus - 2022-04-11 at 15 09 46

Fixes bug(s)

@monsieurtanuki
fix: openfoodfacts#1537 - moved the "slack" and "email" contact options
7259cc6 
Impacted files:
* `smooth_main_button.dart`: added a `TODO` about probable deleting of this class.
* `social_handle_view.dart`: moved there "slack" and "email" contact options; refactored
* `user_preferences_settings.dart`: removed the "support" (slack or email) button
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner April 11, 2022 13:11
@monsieurtanuki monsieurtanuki requested a review from M123-dev April 11, 2022 13:11
M123-dev
M123-dev approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @monsieurtanuki

@monsieurtanuki monsieurtanuki merged commit 47c53f7 into openfoodfacts:develop Apr 11, 2022
@github-actions github-actions bot mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monsieurtanuki @M123-dev