Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1585 Limited username to 20 characters #1605

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

vik4114
Copy link
Contributor

@vik4114 vik4114 commented Apr 21, 2022

What

fix: #1585 Limited username to 20 characters

Screenshot

Before
Screenshot_1650546228

After
Screenshot_1650546217

Fixes bug(s)

@vik4114 vik4114 requested a review from a team as a code owner April 21, 2022 13:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #1605 (c8bfdeb) into develop (2ea0da3) will decrease coverage by 0.12%.
The diff coverage is 1.56%.

@@            Coverage Diff             @@
##           develop   #1605      +/-   ##
==========================================
- Coverage     8.86%   8.73%   -0.13%     
==========================================
  Files          161     164       +3     
  Lines         6623    6776     +153     
==========================================
+ Hits           587     592       +5     
- Misses        6036    6184     +148     
Impacted Files Coverage Δ
...rds/knowledge_panels/knowledge_panels_builder.dart 2.17% <0.00%> (ø)
...s/product_cards/smooth_product_card_not_found.dart 0.00% <0.00%> (ø)
...mooth_app/lib/data_models/product_query_model.dart 1.38% <ø> (ø)
...s/smooth_app/lib/data_models/user_preferences.dart 34.42% <ø> (+2.11%) ⬆️
...s/smooth_app/lib/database/dao_string_list_map.dart 0.00% <0.00%> (ø)
...ckages/smooth_app/lib/database/local_database.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/database/paged_product_query.dart 0.00% <0.00%> (ø)
...oth_app/lib/database/robotoff_questions_query.dart 0.00% <0.00%> (ø)
...ric_lib/buttons/smooth_large_button_with_icon.dart 0.00% <0.00%> (ø)
...ges/smooth_app/lib/generic_lib/loading_dialog.dart 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f671807...c8bfdeb. Read the comment docs.

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for your work!

@g123k g123k merged commit 5c003a6 into openfoodfacts:develop Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit usernames to 20 chars
4 participants