Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit usernames to 20 chars #1585

Closed
teolemon opened this issue Apr 16, 2022 · 8 comments · Fixed by #1605
Closed

Limit usernames to 20 chars #1585

teolemon opened this issue Apr 16, 2022 · 8 comments · Fixed by #1605
Assignees
@vik4114
Labels
✅ task

Comments

@teolemon
Copy link
Member

What
@g123k g123k mentioned this issue Apr 16, 2022
Closed
@g123k
Copy link
Collaborator

g123k commented Apr 16, 2022 •
edited
Loading

Should be first implemented in the SDK

@vik4114
Copy link
Contributor

vik4114 commented Apr 18, 2022

I will take this

@g123k
Copy link
Collaborator

g123k commented Apr 18, 2022

@vik4114 Please wait before coding anything, as this issue depends on openfoodfacts/openfoodfacts-dart#441

@vik4114
Copy link
Contributor

vik4114 commented Apr 18, 2022

@g123k Okay

@M123-dev
Copy link
Member

SDK implementation merged, we probably don't need to release with the changes immediately, do we?

@g123k
Copy link
Collaborator

g123k commented Apr 18, 2022 •
edited
Loading

Unfortunately yes, otherwise the constant USER_NAME_MAX_LENGTH won't be accessible
https://github.com/openfoodfacts/openfoodfacts-dart/pull/442/files#diff-12c713b3c900cad49c9548b90c7fc1610488231db67db7aa1bef21fcfee5c96dR773

@M123-dev
Copy link
Member

Going to release this evening

@M123-dev
Copy link
Member

The new off-dart version with the max length const should be release any second now

@vik4114 vik4114 mentioned this issue Apr 21, 2022
Merged
g123k pushed a commit that referenced this issue Apr 22, 2022
@vik4114
fix: #1585 Limited username to 20 characters (#1605)
5c003a6 
* Limited username to 20 characters
@github-actions github-actions bot mentioned this issue Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vik4114 vik4114

Labels
✅ task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #1585 Limited username to 20 characters vik4114/smooth-app
4 participants
@g123k @teolemon @M123-dev @vik4114