Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limit usernames to 20 characters #6631

Merged
merged 5 commits into from
Apr 28, 2022
Merged

fix: limit usernames to 20 characters #6631

merged 5 commits into from
Apr 28, 2022

Conversation

stephanegigandet
Copy link
Contributor

No description provided.

@stephanegigandet stephanegigandet requested a review from a team as a code owner April 15, 2022 14:22
@github-actions github-actions bot added Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users labels Apr 15, 2022
@teolemon teolemon mentioned this pull request Apr 16, 2022
Closed
alexgarel
alexgarel approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would like you to add a test on user name.

@github-actions github-actions bot added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Apr 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alexgarel
alexgarel approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + testé ok

@alexgarel alexgarel merged commit 29a739b into main Apr 28, 2022
@alexgarel alexgarel deleted the user-spam branch April 28, 2022 10:58
@alexgarel alexgarel mentioned this pull request Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees
No one assigned
Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanegigandet @alexgarel @VaiTon