Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed languages in settings #1673

Closed
1 task
teolemon opened this issue Apr 27, 2022 · 2 comments · Fixed by #1759
Closed
1 task

Mixed languages in settings #1673

teolemon opened this issue Apr 27, 2022 · 2 comments · Fixed by #1759
Labels
🐛 bug Something isn't working 🌐 l10n ⚙️ Settings
Milestone
V1

Comments

@teolemon
Copy link
Member

What

  • Mixed languages in settings

image
@teolemon teolemon added 🐛 bug Something isn't working ⚙️ Settings labels Apr 27, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon That's not very fair to say "Mixed languages in settings", or to call it a bug.
More generally, you want to be able to switch languages on your smartphone and that everything on the app changes to the new language: new localizations and refreshed metadata (including products).
It's not like smoothie has bugs and is designed to display random language localizations; in a normal use-case (always the same language) this issue does not happen.
I understand the logic and the advanced use-case, but it's not a bug alert, it's more an advanced feature requirement.

@teolemon teolemon added this to the V1 milestone Apr 28, 2022
@monsieurtanuki
Copy link
Contributor

My bad: there was actually an "advanced" bug.
If you go from language A to language B to language C, no problem.
But then, if you go back to language A or B that doesn't work, we are stuck with language C. Quickly said: the reason why that we had already dowloaded and stored locally the preferences, and that the values didn't change between what was stored and what we've just downloaded: no change, no refresh. I've just added a test "if we changed languages, force refresh". In a PR, very very soon.

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue May 5, 2022
@monsieurtanuki
fix: openfoodfacts#1673 - force preferences refresh when we changed l…
cee21cf 
…anguages

Impacted file:
* `product_preferences.dart`
@monsieurtanuki monsieurtanuki mentioned this issue May 5, 2022
Merged
monsieurtanuki added a commit that referenced this issue May 6, 2022
@monsieurtanuki
fix: #1673 - force preferences refresh when we changed languages (#1759)
4b053d8 
Impacted file:
* `product_preferences.dart`
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 6, 2022
@github-actions github-actions bot mentioned this issue May 6, 2022
Closed
@hangy hangy mentioned this issue Jun 30, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🌐 l10n ⚙️ Settings
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: #1673 - force preferences refresh when we changed languages monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki