Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The load product from internet loops infinitely, on good networks, during onboarding #1697

Closed
1 task
teolemon opened this issue Apr 29, 2022 · 0 comments · Fixed by #1705
Closed
1 task

The load product from internet loops infinitely, on good networks, during onboarding #1697

teolemon opened this issue Apr 29, 2022 · 0 comments · Fixed by #1705
Assignees
@monsieurtanuki
Labels
🐛 bug Something isn't working 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Apr 29, 2022 •
edited
Loading

What

  • The load product from internet loops infinitely, on good networks, during onboarding

Part of
@teolemon teolemon added 🐛 bug Something isn't working 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… labels Apr 29, 2022
@teolemon teolemon added this to the V1 milestone Apr 29, 2022
@monsieurtanuki monsieurtanuki self-assigned this Apr 29, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Apr 29, 2022
@monsieurtanuki
fix: openfoodfacts#1697 - checking hasError instead of hasData in Fut…
fea06f5 
…ureBuilder

Impacted file:
* `loading_dialog.dart`: checking hasError instead of hasData - hasData is not reliable as data can be void or null.
@monsieurtanuki monsieurtanuki mentioned this issue Apr 29, 2022
Merged
@monsieurtanuki monsieurtanuki linked a pull request Apr 29, 2022 that will close this issue
fix: #1697 - checking hasError instead of hasData in FutureBuilder #1705
Merged
monsieurtanuki added a commit that referenced this issue Apr 29, 2022
@monsieurtanuki
fix: #1697 - checking hasError instead of hasData in FutureBuilder (#…
20a9da0 
…1705)

Impacted file:
* `loading_dialog.dart`: checking hasError instead of hasData - hasData is not reliable as data can be void or null.
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 29, 2022
@github-actions github-actions bot mentioned this issue Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🐛 bug Something isn't working 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: #1697 - checking hasError instead of hasData in FutureBuilder monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki