Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1697 - checking hasError instead of hasData in FutureBuilder #1705

Merged
merged 1 commit into from
Apr 29, 2022
Merged

fix: #1697 - checking hasError instead of hasData in FutureBuilder #1705

merged 1 commit into from
Apr 29, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • loading_dialog.dart: checking hasError instead of hasData - hasData is not reliable as data can be void or null.

What

  • Interesting case!
  • Here we use LoadingDialog.run<void>. Therefore if we test snapshot.hasData, we'll always get false (as void is not really a data).
  • When the snapshot is "done", it's either hasError or successful.
  • This PR is just about moving the tests order.
  • The app does not look good a few pages after, but that's another story.

Fixes bug(s)

@monsieurtanuki
fix: openfoodfacts#1697 - checking hasError instead of hasData in Fut…
fea06f5 
…ureBuilder

Impacted file:
* `loading_dialog.dart`: checking hasError instead of hasData - hasData is not reliable as data can be void or null.
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner April 29, 2022 13:36
@monsieurtanuki monsieurtanuki linked an issue Apr 29, 2022 that may be closed by this pull request
The load product from internet loops infinitely, on good networks, during onboarding #1697
Closed
1 task
@monsieurtanuki monsieurtanuki merged commit 20a9da0 into openfoodfacts:develop Apr 29, 2022
@github-actions github-actions bot mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The load product from internet loops infinitely, on good networks, during onboarding
2 participants
@monsieurtanuki @M123-dev