Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Product remove cross is too small #1718

Merged
merged 2 commits into from
Apr 30, 2022
Merged

fix: Product remove cross is too small #1718

merged 2 commits into from
Apr 30, 2022

Conversation

bhattabhi013
Copy link
Contributor

What

Fixes size issue of product removal cross on product_title_card.dart

Screenshot

image

Fixes bug(s)

Part of

@bhattabhi013 bhattabhi013 requested a review from a team as a code owner April 29, 2022 20:18
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #1718 (8a7d007) into develop (2ea0da3) will decrease coverage by 0.56%.
The diff coverage is 0.68%.

@@            Coverage Diff             @@
##           develop   #1718      +/-   ##
==========================================
- Coverage     8.86%   8.30%   -0.57%     
==========================================
  Files          161     165       +4     
  Lines         6623    7118     +495     
==========================================
+ Hits           587     591       +4     
- Misses        6036    6527     +491     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9653f17...8a7d007. Read the comment docs.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bhattabhi013!
Not sure if we shouldn't rather have the initial icon size with a 48 touchable area, but that's good enough!

@teolemon
Copy link
Member

small merge conflict @bhattabhi013

@bhattabhi013
Copy link
Contributor Author

small merge conflict @bhattabhi013

Resolved conflicts @teolemon.

@teolemon
Copy link
Member

thanks @bhattabhi013 👍
merging

@teolemon teolemon merged commit 93f790c into openfoodfacts:develop Apr 30, 2022
@teolemon teolemon linked an issue Apr 30, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Product remove cross is too small
4 participants