-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Product remove cross is too small #1718
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1718 +/- ##
==========================================
- Coverage 8.86% 8.30% -0.57%
==========================================
Files 161 165 +4
Lines 6623 7118 +495
==========================================
+ Hits 587 591 +4
- Misses 6036 6527 +491
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bhattabhi013!
Not sure if we shouldn't rather have the initial icon size with a 48
touchable area, but that's good enough!
small merge conflict @bhattabhi013 |
Resolved conflicts @teolemon. |
thanks @bhattabhi013 👍 |
What
Fixes size issue of product removal cross on
product_title_card.dart
Screenshot
Fixes bug(s)
Part of
(please be as granular as possible)