-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1667 Added placeholder image #1733
Conversation
Added placeholder image when no internet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @vik4114 just one small comment
packages/smooth_app/lib/cards/data_cards/image_upload_card.dart
Outdated
Show resolved
Hide resolved
Hi @vik4114, Here are a few comments on your PR:
|
Codecov Report
@@ Coverage Diff @@
## develop #1733 +/- ##
==========================================
- Coverage 8.86% 8.09% -0.77%
==========================================
Files 161 168 +7
Lines 6623 7350 +727
==========================================
+ Hits 587 595 +8
- Misses 6036 6755 +719
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot @vik4114
What
-Added placeholder image when no internet
Screenshot
WhatsApp.Video.2022-05-03.at.12.28.39.AM.mp4
Fixes bug(s)