Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1667 Added placeholder image #1733

Merged
merged 3 commits into from
May 10, 2022
Merged

Conversation

vik4114
Copy link
Contributor

@vik4114 vik4114 commented May 2, 2022

What

-Added placeholder image when no internet

Screenshot

WhatsApp.Video.2022-05-03.at.12.28.39.AM.mp4

Fixes bug(s)

Added placeholder image when no internet
@vik4114 vik4114 requested a review from a team as a code owner May 2, 2022 19:46
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @vik4114 just one small comment

@g123k
Copy link
Collaborator

g123k commented May 3, 2022

Hi @vik4114,

Here are a few comments on your PR:

@teolemon teolemon added image carousel https://github.com/openfoodfacts/smooth-app/issues/966 Offline labels May 4, 2022
@teolemon teolemon added this to the V1 milestone May 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1733 (e592586) into develop (2ea0da3) will decrease coverage by 0.76%.
The diff coverage is 0.66%.

@@            Coverage Diff             @@
##           develop   #1733      +/-   ##
==========================================
- Coverage     8.86%   8.09%   -0.77%     
==========================================
  Files          161     168       +7     
  Lines         6623    7350     +727     
==========================================
+ Hits           587     595       +8     
- Misses        6036    6755     +719     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...th_app/lib/cards/data_cards/image_upload_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee733a...e592586. Read the comment docs.

@vik4114
Copy link
Contributor Author

vik4114 commented May 7, 2022

New Screenshot
Screenshot_1651933680

@vik4114 vik4114 requested a review from M123-dev May 10, 2022 14:39
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot @vik4114

@M123-dev M123-dev merged commit 5e736eb into openfoodfacts:develop May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
image carousel https://github.com/openfoodfacts/smooth-app/issues/966 Offline
Development

Successfully merging this pull request may close these issues.

Show something in the photo carousel when no internet connection
5 participants