Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement simplified origin input #2501

Closed
1 task
teolemon opened this issue Jul 5, 2022 · 1 comment · Fixed by #2571
Closed
1 task

Implement simplified origin input #2501

teolemon opened this issue Jul 5, 2022 · 1 comment · Fixed by #2571
Assignees
@monsieurtanuki
Labels
✏️ Editing - Tags P2

Comments

@teolemon
Copy link
Member

teolemon commented Jul 5, 2022 •
edited
Loading

What

  • In addition to origin extraction from the ingredient list, we now parse the origin of ingredients field for Eco-Score computation. - It's a tag-based field that works like the others.
  • Implement simplified origin input (by duplicating what we do for other tag fields)

Image

Part of
@teolemon teolemon mentioned this issue Jul 9, 2022
Closed
8 tasks
@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 9, 2022
@teolemon
Copy link
Member Author

teolemon commented Jul 9, 2022 •
edited
Loading

@monsieurtanuki could you add origins of ingredients editing by cloning the tag editing view (eg for stores) ?
Sifting through user reviews, that's something people want back in the new app.

User 1: "Le calcul Ecoscore est erroné, car il applique une pénalité de -5 point, alors que l’origine des ingrédients est connu, mais ne peut être ajoutée dans la base depuis la nouvelle appli."
User 2: "Impossible d'ajouter les origines des ingrédients. NB: Je les ajoute dans "labels" en attendant."

@monsieurtanuki monsieurtanuki self-assigned this Jul 10, 2022
@monsieurtanuki monsieurtanuki mentioned this issue Jul 10, 2022
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 11, 2022
@monsieurtanuki
feat: openfoodfacts#2501 - added "origins" in edit product page
8e9881b 
Impacted files:
* `app_en.arb`: added 2 labels for "origins"
* `app_fr.arb`: added 2 labels for "origins"
* `edit_product_page.dart`: added an item for "origins"
* `product_query.dart`: added field "origins" to the list of the product fields we retrieve
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded to `openfoodfacts: ^1.22.0`, which has new product field "origins"
* `simple_input_page_helpers.dart`: implementation for "origins" of a simple input page item
@monsieurtanuki monsieurtanuki mentioned this issue Jul 11, 2022
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 11, 2022
@monsieurtanuki
feat: openfoodfacts#2501 - icon for "origins"
8048d59 
Impacted files:
* `simple_input_page_helpers.dart`
teolemon added a commit that referenced this issue Jul 11, 2022
@monsieurtanuki @teolemon
feat: #2501 - added "origins" in edit product page (#2571)
2b60cb5 
* feat: #2501 - added "origins" in edit product page

Impacted files:
* `app_en.arb`: added 2 labels for "origins"
* `app_fr.arb`: added 2 labels for "origins"
* `edit_product_page.dart`: added an item for "origins"
* `product_query.dart`: added field "origins" to the list of the product fields we retrieve
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded to `openfoodfacts: ^1.22.0`, which has new product field "origins"
* `simple_input_page_helpers.dart`: implementation for "origins" of a simple input page item

* feat: #2501 - icon for "origins"

Impacted files:
* `simple_input_page_helpers.dart`

* Update packages/smooth_app/lib/l10n/app_en.arb

Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>

Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 11, 2022
@github-actions github-actions bot mentioned this issue Jul 19, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
✏️ Editing - Tags P2
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #2501 - added "origins" in edit product page monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki