Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up product usage logging for core features #501

Closed
18 of 21 tasks
Tracked by #500
, #309
...
teolemon opened this issue Aug 19, 2021 · 6 comments · Fixed by #2264
Closed
18 of 21 tasks
Tracked by #500
, #309
...

Set up product usage logging for core features #501

teolemon opened this issue Aug 19, 2021 · 6 comments · Fixed by #2264
Assignees
@M123-dev
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system 🎯 P1 Sentry
Milestone
V1.1

Comments

@teolemon
Copy link
Member

teolemon commented Aug 19, 2021 •
edited by M123-dev
Loading

What

This implies:

  • Adding an analytics engine #309
  • Migrate to sentry_flutter #480
  • UI work for logging consent
  • Implement an analytics consent UI #1158
    • We should also ensure we can enable/disable it at any time
      image
  • Implementation of logging events
  • defining a list of what we want to log
    • Knowledge Panel taps, views and extensions
    • Interaction with settings
    • Interaction with search
    • Interaction with onboarding
    • Interaction with history
    • Scans
    • Expansion of a scan result
    • Triggering of custom search from scans
    • Triggering of custom search from search
    • Triggering of custom search from history
    • Signups from the app
    • Logins from the app
    • Language
    • Country

Part of
@teolemon teolemon mentioned this issue Aug 19, 2021
Closed
8 tasks
@teolemon teolemon mentioned this issue Aug 20, 2021
Closed
1 task
@M123-dev
Copy link
Member

@teolemon what is P0 the consent UI of course but also tracking?

Tracking is definitely nice to have, what would be the core features you would like to track

@teolemon
Copy link
Member Author

Tentatively: scan volume, product page opening volume, knowledge panel opening volume, search volume, personal search volume

@M123-dev M123-dev self-assigned this Feb 13, 2022
@M123-dev M123-dev mentioned this issue Feb 16, 2022
Merged
@M123-dev
Copy link
Member

@teolemon @monsieurtanuki

Regarding asking for user consent:

  • two checks (Bug reports / Analytics)
  • or just one for both

@monsieurtanuki
Copy link
Contributor

I have no strong opinion about that. In that case I would check what they do on "standard" apps.
In France the official covid app ("Tous Anti Covid") there's just one switch for statistics:
Screenshot_2022-02-18-19-52-34
And now that I'm thinking, on every app that crashes, there's some kind of official crash report where the user clicks (or not) a "send button" report, with optional additional comments.
What does Sentry recommend?

@teolemon
Copy link
Member Author

  • Frankly analytics and debugging are not the same, so 2 buttons if that's not more complex IMO.
  • I'd rather not introduce a manual step for bug reports though.

@M123-dev M123-dev removed their assignment Mar 10, 2022
@monsieurtanuki monsieurtanuki self-assigned this Mar 13, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Mar 13, 2022
@monsieurtanuki
feat: openfoodfacts#501 - added switches in preferences for crash and…
5f5d790 
… analytics reports

Impacted files:
* `analytics_helper.dart`: added 2 static bool fields to say if we should or not send crash and analytics reports
* `main.dart`: init of the crash and analytics report flags
* `user_preferences.dart`: getters/setters for the report flags
* `user_preferences_profile.dart`: added switches for the report flags
@monsieurtanuki monsieurtanuki mentioned this issue Mar 13, 2022
Merged
monsieurtanuki added a commit that referenced this issue Mar 13, 2022
@monsieurtanuki
feat: #501 - added switches in preferences for crash and analytics re…
1dc1454 
…ports (#1207)

Impacted files:
* `analytics_helper.dart`: added 2 static bool fields to say if we should or not send crash and analytics reports
* `main.dart`: init of the crash and analytics report flags
* `user_preferences.dart`: getters/setters for the report flags
* `user_preferences_profile.dart`: added switches for the report flags
@github-actions github-actions bot mentioned this issue Mar 13, 2022
Closed
@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
@monsieurtanuki monsieurtanuki removed their assignment Apr 7, 2022
@teolemon teolemon modified the milestones: V1, V1.1 Apr 11, 2022
@M123-dev M123-dev self-assigned this May 24, 2022
@teolemon teolemon added 🎯 P1 and removed 🎯 P0 labels May 25, 2022
@M123-dev M123-dev added the 📈 Analytics We use Sentry and Matomo, with an opt-in system label May 26, 2022
@M123-dev M123-dev mentioned this issue Jun 13, 2022
Merged
@M123-dev
Copy link
Member

Everything besides the onboarding and the settings is done after #2264 @teolemon

  • Settings: What should we track there, everything seems a little too much
  • Onboarding: We can't or better shouldn't track before we ask if we are allowed to

Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@M123-dev M123-dev

Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system 🎯 P1 Sentry
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1.1
Development

Successfully merging a pull request may close this issue.

feat: Matomo refinements openfoodfacts/smooth-app
3 participants
@teolemon @monsieurtanuki @M123-dev