Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Prices deeplinking #5648

Closed
Tracked by #4016
teolemon opened this issue Sep 30, 2024 · 3 comments · Fixed by #5734
Closed
Tracked by #4016

Add Open Prices deeplinking #5648

teolemon opened this issue Sep 30, 2024 · 3 comments · Fixed by #5734
Assignees
Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps good first issue Good for newcomers Prices

Comments

@teolemon
Copy link
Member

No description provided.

@monsieurtanuki
Copy link
Contributor

Looks like GoRouter does accept subdomains, but won't give access to the subdomain value.

For instance, we can say "please deep-link https://prices.openfoodfacts.org/ to Smoothie" but we'll land in the unique "/" home page - as for https://world.openfoodfacts.org/ and https://at-en.openbeautyfacts.org/ - therefore in a page unrelated to prices. @g123k Am I right?

@teolemon Would that be OK to land just on the generic Smoothie Home page from https://prices.openfoodfacts.org/ as a deep-link?

@g123k
Copy link
Collaborator

g123k commented Oct 25, 2024

Currently, GoRouter doesn't provide the subdomain, but I'm pretty sure Android and iOS know it.
There are other dependencies for deep links and I will check if we can get it from the Flutter side.

@monsieurtanuki
Copy link
Contributor

Thank you @g123k for your quick answer!

Probably in that case linking to the home page would be good enough in a first approach.
Accessing the subdomain would be nice, but may not be worth the trouble. Depends on what you find and how easy it is to implement and maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps good first issue Good for newcomers Prices
Development

Successfully merging a pull request may close this issue.

3 participants