feat: 5648 - deep link for Prices (+ OxF fixes) #5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `AndroidManifest.xml`: added an entry for Prices regarding deeplinks * `launch_url_helper.dart`: added beauty, products and petfood regarding deeplinks * `Runner.entitlements`: added an entry for Prices, beauty, products and petfood regarding deeplinks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5734 +/- ##
==========================================
- Coverage 9.54% 7.00% -2.55%
==========================================
Files 325 406 +81
Lines 16411 21655 +5244
==========================================
- Hits 1567 1516 -51
- Misses 14844 20139 +5295 ☔ View full report in Codecov by Sentry. |
g123k
reviewed
Oct 25, 2024
|
|
||
|
|
||
| <!-- Prices --> | ||
| <data android:scheme="http" android:host="prices.openfoodfacts.org" /> |
There was a problem hiding this comment.
Maybe you should add, the .net variant.
Is-it relevant @teolemon?
teolemon
approved these changes
Oct 25, 2024
|
@monsieurtanuki I was wrong about the domain. |
Good news! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Impacted files
AndroidManifest.xml: added an entry for Prices regarding deeplinkslaunch_url_helper.dart: added beauty, products and petfood regarding deeplinksRunner.entitlements: added an entry for Prices, beauty, products and petfood regarding deeplinks