Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to switch to OpenFoodFacts.net/dev from the hidden settings #848

Closed
teolemon opened this issue Jan 4, 2022 · 2 comments · Fixed by #851
Closed

Allow to switch to OpenFoodFacts.net/dev from the hidden settings #848

teolemon opened this issue Jan 4, 2022 · 2 comments · Fixed by #851
Assignees
@monsieurtanuki
Labels
devops

Comments

@teolemon
Copy link
Member

teolemon commented Jan 4, 2022 •
edited
Loading

What

  • In order to speed up Knowledge panel testing, allow to switch to OpenFoodFacts.net/dev from the hidden settings

Part of
@monsieurtanuki monsieurtanuki self-assigned this Jan 4, 2022
@teolemon
Copy link
Member Author

teolemon commented Jan 4, 2022

@monsieurtanuki I would love if we could also enable forcing to openbeautyfacts.org/net, openpetfoodfacts.org/net, openproductsfacts.org/net to see how bad the app crashes.

@teolemon teolemon changed the title Allow switch to OpenFoodFacts.net/dev from the hidden settings Allow to switch to OpenFoodFacts.net/dev from the hidden settings Jan 4, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 4, 2022
@monsieurtanuki
feat: openfoodfacts#848 - dev mode - item that switches the QueryType…
ef4b21a 
… to PROD and DEV

Impacted files:
* `knowledge_panels_query.dart`: not using systematically `QueryType.PROD` anymore
* `main.dart`: at init time, sets the correct query type from preferences
* `product_query.dart`: new method `setQueryType` that uses the preferences to set the query type
* `user_preferences_dev_mode.dart`: added an item that switches the `QueryType` to `PROD` and `DEV`
@monsieurtanuki
Copy link
Contributor

@teolemon You can do that right now:

OpenFoodAPIConfiguration.uriProdHost = 'world.openwhatever.org';

@monsieurtanuki monsieurtanuki linked a pull request Jan 4, 2022 that will close this issue
feat: #848 - dev mode - item that switches the QueryType to PROD and DEV #851
Merged
monsieurtanuki added a commit that referenced this issue Jan 4, 2022
@monsieurtanuki
feat: #848 - dev mode - item that switches the QueryType to PROD and …
03be267 
…DEV (#851)

Impacted files:
* `knowledge_panels_query.dart`: not using systematically `QueryType.PROD` anymore
* `main.dart`: at init time, sets the correct query type from preferences
* `product_query.dart`: new method `setQueryType` that uses the preferences to set the query type
* `user_preferences_dev_mode.dart`: added an item that switches the `QueryType` to `PROD` and `DEV`
@github-actions github-actions bot mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #848 - dev mode - item that switches the QueryType to PROD and DEV monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki