Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a compare button on Product History page #878

Closed
3 tasks
Tracked by #655
teolemon opened this issue Jan 7, 2022 · 3 comments · Fixed by #1035
Closed
3 tasks
Tracked by #655

Add a compare button on Product History page #878

teolemon opened this issue Jan 7, 2022 · 3 comments · Fixed by #1035
Assignees
@monsieurtanuki
Labels
compare mode help wanted Extra attention is needed history 🎯 P0

Comments

@teolemon
Copy link
Member

teolemon commented Jan 7, 2022 •
edited
Loading

What

  • Add a compare button on Product History page
    • when this button is pressed the user can select all products they want to compare.
    • Open a comparison page that should reuse most of the components from Product History page.

Mocks

image
@teolemon teolemon mentioned this issue Jan 7, 2022
Closed
42 tasks
@teolemon teolemon changed the title Add a compare button on Product History page, when this button is pressed the user can select all products they want to compare. Open a comparison page that should reuse most of the components from Product History page. Add a compare button on Product History page Jan 7, 2022
@teolemon teolemon mentioned this issue Jan 14, 2022
Closed
6 tasks
@teolemon teolemon added 🎯 P0 help wanted Extra attention is needed labels Jan 14, 2022
@teolemon teolemon mentioned this issue Jan 15, 2022
Closed
11 tasks
@monsieurtanuki monsieurtanuki self-assigned this Jan 18, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon There's already a "personalized ranking" button at the bottom of the page. Not sure how relevant it would be to add buttons to the top, UX-wise:
Simulator Screen Shot - iPhone 8 Plus - 2022-01-27 at 17 13 13

@monsieurtanuki
Copy link
Contributor

We also don't have that much horizontal space for the suggested "checked product" UI:
Simulator Screen Shot - iPhone 8 Plus - 2022-01-27 at 17 38 30

@teolemon
Copy link
Member Author

The products are supposed to slide right, leaving space for the selection boxes.
On the compare button, the text at least needs to change.

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 28, 2022
@monsieurtanuki
feat: openfoodfacts#878 - added a multiselect mode to product list page
3bda01d 
Impacted files:
* `personalized_ranking_page.dart`: added a `fromItems` constructor for more flexibility
* `product_list_item_simple.dart`: added optional `onTap` parameter in order to override the default behavior when checking/unchecking
* `product_list_page.dart`: added a "multiselect" mode
* `product_query_page.dart`: refactored
* `scan_page_helper.dart`: refactored
* `smooth_it_model.dart`: for flexibility, now using `List<Product>` instead of `ProductList`
* `smooth_product_card_found.dart`: added optional `onTap` parameter in order to override the default behavior when checking/unchecking
@teolemon teolemon mentioned this issue Jan 28, 2022
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 28, 2022
@monsieurtanuki
feat: openfoodfacts#878 - added header with buttons; removed FABs
5dc6b48 
Impacted files:
* `product_list_page.dart`: added header with buttons; removed FABs
* `ranking_floating_action_button.dart`: added a comment about getting rid of this class because of possible confusion
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 28, 2022
@monsieurtanuki
feat: openfoodfacts#878 - one cancel button is enough
b4098ba 
Impacted files:
* `product_list_page.dart`: added header with buttons; removed FABs
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 28, 2022
@monsieurtanuki
feat: openfoodfacts#878 - closer to the mocks
ef6c91a 
Impacted file:
* `product_list_page.dart`: closer to the mocks
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 29, 2022
@monsieurtanuki
feat: openfoodfacts#878 - unrelated minor refactoring
aa39bb8 
Impacted file:
* `product_query.dart`: unrelated removal of a harmless duplicate
@teolemon teolemon linked a pull request Jan 30, 2022 that will close this issue
feat: #878 - added a multiselect mode to product list page #1035
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 31, 2022
@monsieurtanuki
feat: openfoodfacts#878 - UX fine-tuning
6923e96 
Impacted files:
* `app_en.arb`: added a "compare mode" label
* `app_fr.arb`: added a "compare mode" label
* `product_list_item_simple.dart`: added a `onLongPress` parameter
* `product_list_page.dart`: added longPress-to-selection-mode feature; fixed the cancel button position; localized
monsieurtanuki added a commit that referenced this issue Jan 31, 2022
@monsieurtanuki
feat: #878 - added a multiselect mode to product list page (#1035)
44cd470 
Impacted files:
* `app_en.arb`: added a "compare mode" label
* `app_fr.arb`: added a "compare mode" label
* `personalized_ranking_page.dart`: added a `fromItems` constructor for more flexibility
* `product_list_item_simple.dart`: added optional `onTap` parameter in order to override the default behavior when checking/unchecking, and an optional `onLongPress` parameter in order to trigger selection mode
* `product_list_page.dart`: added a "multiselect" mode and a header with buttons; removed FABs; added longPress-to-selection-mode feature
* `product_query.dart`: unrelated removal of a harmless duplicate
* `product_query_page.dart`: refactored
* `ranking_floating_action_button.dart`: added a comment about getting rid of this class because of possible confusion
* `scan_page_helper.dart`: refactored
* `smooth_it_model.dart`: for flexibility, now using `List<Product>` instead of `ProductList`
* `smooth_product_card_found.dart`: added optional `onTap` parameter in order to override the default behavior when checking/unchecking
Repository owner moved this from Todo to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jan 31, 2022
@github-actions github-actions bot mentioned this issue Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
compare mode help wanted Extra attention is needed history 🎯 P0
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #878 - added a multiselect mode to product list page monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki