Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #899 - avoid to reload the product in onboarding #902

Merged
merged 13 commits into from
Jan 9, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Closes #899

Impacted file:

  • preferences_page.dart: split in two the process - load product and then display it with preferences

Impacted files:
* `smooth_app/pubspec.yaml`: upgrade to openfoodfacts 1.9.1
* `smooth_app/pubspec.lock`: impacted by pubspec.yaml
* `smooth_ui_library/pubspec.yaml`: upgrade to openfoodfacts 1.9.1
* `smooth_ui_library/pubspec.lock`: impacted by pubspec.yaml
* `smooth_ui_library/example/pubspec.lock`: impacted by pubspec.yaml
@teolemon teolemon added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Jan 9, 2022
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@monsieurtanuki monsieurtanuki merged commit cb320e6 into openfoodfacts:develop Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter onboarding is flashing and jumping up
3 participants