Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Refresh product on image upload from new product page #1039

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Fix: Refresh product on image upload from new product page #1039

merged 1 commit into from
Jan 28, 2022

Conversation

jasmeet0817
Copy link
Contributor

@jasmeet0817 jasmeet0817 commented Jan 28, 2022 •
edited
Loading

Currently we have a bug:

  • Open Product page
  • Add a new picture
  • Product page shows the new picture (because ImageUploadCard's state is updated)
  • Navigate out of product page
  • Go back to the product.
  • The image is not there anymore
  • refreshing the product brings the image back

Since the product is "dirty" after uploading the image, we should update it from the server.

@jasmeet0817 jasmeet0817 mentioned this pull request Jan 28, 2022
Closed
@jasmeet0817 jasmeet0817 merged commit 173b7fc into openfoodfacts:develop Jan 28, 2022
@github-actions github-actions bot mentioned this pull request Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

Assignees
No one assigned
Labels
image upload 🥫 Product page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasmeet0817 @monsieurtanuki @teolemon