Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for the Android 12 new splash screen system #1053

Closed
wants to merge 2 commits into from

Conversation

M123-dev
Copy link
Member

@M123-dev M123-dev commented Jan 31, 2022

Now we support Android 12 splash screens

@M123-dev M123-dev requested a review from teolemon January 31, 2022 17:11
@github-actions github-actions bot added Android 🍎 iOS iOS specific issues or PRs labels Jan 31, 2022
@monsieurtanuki
Copy link
Contributor

@M123-dev Please remind me: is there a good reason why we switch to Android 12 (aka 31)? In my apps a user reported me another bug due to Android 12.

@M123-dev
Copy link
Member Author

M123-dev commented Jan 31, 2022

@monsieurtanuki when we added permission_handler for asking for camera permission I checked if we fully switched to AndroidX (since the package needs it) and then upgraded to target version to 31, but android 11 will be probably fine as well. Is android 12 really that buggy

@monsieurtanuki
Copy link
Contributor

@M123-dev If the package needs it and if we need the package, that's solved: go for 31.
But so far 31 is the first Android version upgrade that brought trouble in my Android/java apps, like crash at init time. I started around 21 - that means 9 harmless Android version upgrades before 31.

It's not really bugs, it's about evolutions like: "if this flag is not set, from 31 we crash", or "the Toasts size is less than 16 characters from now on" (instead of possibly several lines).

@M123-dev
Copy link
Member Author

@monsieurtanuki, I am going to try to downgrade the target to 30 for #1038

@M123-dev M123-dev marked this pull request as draft January 31, 2022 17:46
@jasmeet0817
Copy link
Contributor

jasmeet0817 commented Jan 31, 2022 via email

@monsieurtanuki
Copy link
Contributor

AFAICR the country selector library only worked with Android 31 ... (I think)

@jasmeet0817 https://pub.dev/packages/iso_countries: "Android: API level 21 required"

@teolemon teolemon changed the title Splash screen update Support for the Android 12 new splash screen system Feb 5, 2022
@teolemon teolemon changed the title Support for the Android 12 new splash screen system feat: Support for the Android 12 new splash screen system Feb 5, 2022
@M123-dev M123-dev closed this Feb 10, 2022
@M123-dev M123-dev deleted the splash-screen-update branch February 10, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 🍎 iOS iOS specific issues or PRs splashscreen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants