Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close barcode scanner and free it's resources #1181

Merged
merged 7 commits into from
Mar 10, 2022
Merged

fix: Close barcode scanner and free it's resources #1181

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
15a197a
fix: Close barcode scanner and free it's resources
M123-dev Mar 4, 2022
6d33861
Update ml_kit_scan_page.dart
M123-dev Mar 4, 2022
96319b5
Upgraded camera
M123-dev Mar 4, 2022
96a9a04
Update ml_kit_scan_page.dart
M123-dev Mar 10, 2022
517f572
Merge branch 'develop' into ml-kit-ios-second-scan-attempt-fix
M123-dev Mar 10, 2022
e374d02
Update ml_kit_scan_page.dart
M123-dev Mar 10, 2022
9b7a55c
Merge branch 'ml-kit-ios-second-scan-attempt-fix' of https://github.c…
M123-dev Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/smooth_app/lib/pages/scan/ml_kit_scan_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ class MLKitScannerPageState extends State<MLKitScannerPage> {
setState(() {});
}
await _controller?.dispose();
// The barcode scanner gets initialized on the first call to process image
// there is no way and need to manually start it.
barcodeScanner?.close();
_controller?.removeListener(() {});
_controller = null;
}
Expand Down