Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1155 - MissingPluginException (iOS scanner issue) #1210

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix: #1155 - MissingPluginException (iOS scanner issue) #1210

merged 2 commits into from
Mar 16, 2022

Conversation

cli1005
Copy link
Contributor

@cli1005 cli1005 commented Mar 14, 2022 •
edited
Loading

What

Scanner does not work on iOS system due to MissingPluginException thrown, to fix the issue:

  • Replace google_ml_barcode_scanner by google_ml_kit (version 0.6.0)**, since google_ml_barcode_scanner throws MissingPluginException

**: later versions require firebase configuration cause of RemoteModelManager added for iOS since version 0.7 (flutter-ml/google_ml_kit_flutter@aabc7eb)

Screenshot

Tested on iphone 11pro iOS 15:

fix-1155-test-proof.mp4

Fixes bug(s)

Related issue(s)

@cli1005 cli1005 requested a review from a team as a code owner March 14, 2022 13:13
@M123-dev
Copy link
Member

Heyyy and thanks for fixing @cli1005, I think we are fine to merge this as is in order to properly work on iOS unless @teolemon has another opinion on that. But we should definitely make sure to be free of any calls to firebase/google for the final release.

@teolemon
Copy link
Member

on the same line as you @M123-dev

@M123-dev
Copy link
Member

M123-dev commented Mar 15, 2022 •
edited
Loading

Just to make sure, @cli1005 you tested with google_ml_kit and without the firebase project linked, right?

@cli1005
Copy link
Contributor Author

cli1005 commented Mar 16, 2022

Just to make sure, @cli1005 you tested with google_ml_kit and without the firebase project linked, right?

Yes, I tried to remove the firebase dependency, but failed, i will make a second try today 😉

@cli1005
fix: openfoodfacts#1155 - MissingPluginException (iOS scanner issue)
af07202 
- Use an old version of google_ml_kit to remove firebase link
@cli1005
Copy link
Contributor Author

cli1005 commented Mar 16, 2022 •
edited
Loading

Just to make sure, @cli1005 you tested with google_ml_kit and without the firebase project linked, right?

Yes, I tried to remove the firebase dependency, but failed, i will make a second try today 😉

The only approach I found is to use an old version of google_ml_kit, any versions after requires firebase configuration, the PR is updated

@teolemon teolemon added 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… 🍎 iOS iOS specific issues or PRs labels Mar 16, 2022
M123-dev
M123-dev approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks for your efford @cli1005

So okay this will increase the app size by a lot but it's just temporary until we'll find a good way to just use the scanner

@M123-dev M123-dev merged commit 44e9096 into openfoodfacts:develop Mar 16, 2022
@github-actions github-actions bot mentioned this pull request Mar 16, 2022
Closed
@M123-dev M123-dev mentioned this pull request Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
🍎 iOS iOS specific issues or PRs 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cli1005 @M123-dev @teolemon