Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Darkmode scheme on extended panels #1274

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Fixed Darkmode scheme on extended panels #1274

merged 1 commit into from
Mar 20, 2022

Conversation

vik4114
Copy link
Contributor

@vik4114 vik4114 commented Mar 20, 2022

What

Screenshot

Before
Screenshot_1647779270

After
Screenshot_1647779286

Fixes bug(s)

Part of

@vik4114 vik4114 requested a review from a team as a code owner March 20, 2022 12:34
@M123-dev M123-dev mentioned this pull request Mar 20, 2022
Closed
M123-dev
M123-dev approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @vik4114.

By the way, it would be good if you start your PR's with fix: or feat: written exactly like that, then they will be automatically added to the changelog

@M123-dev M123-dev merged commit d15ce49 into openfoodfacts:develop Mar 20, 2022
@github-actions github-actions bot mentioned this pull request Mar 20, 2022
Closed
@vik4114
Copy link
Contributor Author

vik4114 commented Mar 20, 2022

@M123-dev Noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark mode issue (white on white) on extended panels
2 participants
@vik4114 @M123-dev