Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use google_ml_barcode_scanner fork from cli1005 #1302

Merged
merged 5 commits into from
Mar 23, 2022

Conversation

M123-dev
Copy link
Member

Co-Authored-By: cli1005 87010739+cli1005@users.noreply.github.com

What

  • We now use a fork google_ml_barcode_scanner from cli1005 to fix a MissingPluginException on iOS

cf: #1155

Co-Authored-By: cli1005 <87010739+cli1005@users.noreply.github.com>
@cli1005
Copy link
Contributor

cli1005 commented Mar 23, 2022

I created an issue and a PR in https://github.com/danjodanjo/google_ml_barcode_scanner, we could replace my fork repo by the official one once it would be merged.

The fix is builded and tested on my phone(iOS 15.2), no new building warnings has been generated.

@M123-dev
Copy link
Member Author

Sounds good, thanks @cli1005

@M123-dev M123-dev merged commit d98d8f2 into develop Mar 23, 2022
@M123-dev M123-dev deleted the use-ml-barcode-fork branch March 23, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants