Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: robotoff card and dialog design #1365

Merged
merged 3 commits into from
Mar 30, 2022
Merged

feat: robotoff card and dialog design #1365

merged 3 commits into from
Mar 30, 2022

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Mar 28, 2022

What

  • design: better text on background contrast in summary card robotoff card.
  • design: remove whitespace between buttons in robotoff

Screenshot

immagine
immagine

@VaiTon
design: better text on background contrast in summary card robotoff c…
81d7943 
…ard.

design: remove whitespace between buttons in robotoff
@VaiTon VaiTon requested a review from a team as a code owner March 28, 2022 13:02
@VaiTon VaiTon changed the title design: robotoff card and dialog feat: robotoff card and dialog design Mar 28, 2022
teolemon
teolemon approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it brings visual coherence across platforms. Perhaps extracting the color ?

M123-dev
M123-dev approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyy looks great @VaiTon

@VaiTon
Copy link
Member Author

VaiTon commented Mar 28, 2022

Nice, it brings visual coherence across platforms. Perhaps extracting the color ?

Doing it!

@teolemon
Copy link
Member

merging 👍

@teolemon teolemon merged commit 666f6e3 into openfoodfacts:develop Mar 30, 2022
@github-actions github-actions bot mentioned this pull request Mar 30, 2022
Closed
@VaiTon VaiTon deleted the design/robotoff branch March 30, 2022 19:12
@cli1005 cli1005 mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

@teolemon teolemon teolemon approved these changes

Assignees
No one assigned
Labels
🤖 Robotoff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VaiTon @teolemon @M123-dev