-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warning about invalid username and email on user interaction #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but for the email fields, I don't start with my @gmail.com, so I always get a error at the start of my typing. It would be good if you could make onUserInteraction the standard way but allow to pass a different setting for the email field. Probably something like onUnFocus if this exists
Hi, |
Could work, but I fear that this could lead to problems together with focus nodes (#1288) Therfore I think it would be better to use them instead |
Hi @M123-dev , Please let me know if you need any further explanation. |
Yeah @bhattabhi013, I don't know if I understood you correctly but you probably have to create the focus node inside the sign_up_page.dart and not the widget itself in order for it to work. |
Hi @M123-dev ,
I also have a doubt. Do we have to disable AutovalidateMode on the e-mail text field? I'll be glad if you can guide me to the right approach to fix this. |
Thanks for your efford @bhattabhi013 if there is no good and obvious way to solve this currently lets just leave it like this for now and we can always improve later 👍🏼 |
What
fix: warning about invalid username and email on user interaction
Screenshot
alertOnUnfocus.mp4
Fixes bug(s)
Part of
(please be as granular as possible)