feat: Add basic details page UI #1515

bhattabhi013 · 2022-04-07T18:17:53Z

What

Created add basic details page UI.

Video

basic_Details_page.mp4

Fixes bug(s)

Add the ability to add basic details if they are not available #903

Part of

Contribute (Tracker) #503

bhattabhi013 · 2022-04-07T18:24:30Z

I've created the UI part and I have some doubts regarding the submission of data entered by the user.
I referred nutrition_page_loaded.dart for this purpose and found that the data is saved in the local database. Do we have to do the same process for this page too? and if we have to send the data to the back-end then how we are supposed to do it? I will be glad if you can provide any reference for the same. Thanks

M123-dev · 2022-04-07T18:33:54Z

@bhattabhi013 this part should theoretically be not that hard because all querys to open food facts are routed to our other repository openfoodfacts-dart

But actually @monsieurtanuki I'm unsure if the part is already done in off-dart, just did a quick check and we have saveProduct which does a query to the right endpoint (product_jqm2.pl)

But here:

Editing the product
You just have to prefix add_ before the name of the field. Examples:

add_categories
add_labels
add_brands
…

This adds a new value but doesn't delete the previous ones. Adding values doesn't need authentication but take it into account. Examples:
https://world.openfoodfacts.net/cgi/product_jqm2.pl?code=0048151621226&add_brands=Brand%202
https://world.openfoodfacts.net/cgi/product_jqm2.pl?code=0048151621226&user_id=username&password=*****&add_brands=Brand%203

I'm unsure if we add the add_ prefix

monsieurtanuki · 2022-04-07T21:21:57Z

@bhattabhi013 nutrition_page_loaded.dart actually saves the data on the back-end with ProductRefresher.
Btw be careful and switch to the dev environment when you code.

@M123-dev I think the calls you're referring to still need to be implemented, cf. openfoodfacts/openfoodfacts-dart#132 - assuming it's what we need here.

teolemon · 2022-04-09T10:01:01Z

We probably don't need the add_ prefix if we do things properly (we check for pre-existing data, and we offer the user the opportunity to correct or augment it)
The add_ prefix is a safety system if for some reason the app does not have a comprehensive editing system.

monsieurtanuki · 2022-04-09T15:33:17Z

We probably don't need the add_ prefix if we do things properly (we check for pre-existing data, and we offer the user the opportunity to correct or augment it)
The add_ prefix is a safety system if for some reason the app does not have a comprehensive editing system.

@bhattabhi013 Therefore you should use saveProduct, with the barcode and all the values for the field you changed, for instance:

brand was "Coca Cola"
you want to add "Walmart"
you have to save barcode="xxxxx", brand="Coca Cola, Walmart"

M123-dev · 2022-04-19T19:37:59Z

Any updated @bhattabhi013

bhattabhi013 · 2022-04-20T14:00:34Z

Hey @M123-dev,
I'm working on it, I apologize as I was unable to update the ongoing process.
@teolemon @M123-dev, I've got a doubt while using the saveProduct API.
Should I replace the key instead of updating it, for example:

Brand was "Coca Cola"
I want to add "Walmart"
Instead of doing it like brand=" Coca Cola, Walmart" I think of doing it as brand = "Walmart" because I feel having two brands for a single product or 2 product names for a single product doesn't look good.
I would love to hear your suggestions on this.

…/smooth-app into addBasicDetailsPage

codecov-commenter · 2022-04-23T15:35:44Z

Codecov Report

Merging #1515 (995c3b4) into develop (2ea0da3) will decrease coverage by 0.61%.
The diff coverage is 0.66%.

@@            Coverage Diff             @@
##           develop   #1515      +/-   ##
==========================================
- Coverage     8.86%   8.25%   -0.62%     
==========================================
  Files          161     168       +7     
  Lines         6623    7333     +710     
==========================================
+ Hits           587     605      +18     
- Misses        6036    6728     +692

Impacted Files	Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart	`0.00% <0.00%> (ø)`
...p/lib/cards/category_cards/asset_cache_helper.dart	`0.00% <0.00%> (ø)`
...p/lib/cards/category_cards/raster_async_asset.dart	`0.00% <0.00%> (ø)`
...oth_app/lib/cards/category_cards/raster_cache.dart	`0.00% <0.00%> (ø)`
..._app/lib/cards/category_cards/svg_async_asset.dart	`0.00% <0.00%> (ø)`
...smooth_app/lib/cards/category_cards/svg_cache.dart	`0.00% <0.00%> (ø)`
...t_cards/knowledge_panels/knowledge_panel_card.dart	`0.00% <0.00%> (ø)`
...t_cards/knowledge_panels/knowledge_panel_page.dart	`0.00% <0.00%> (ø)`
...knowledge_panels/knowledge_panel_summary_card.dart	`0.00% <ø> (ø)`
...s/knowledge_panels/knowledge_panel_table_card.dart	`0.00% <0.00%> (ø)`
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11488e...995c3b4. Read the comment docs.

bhattabhi013 · 2022-04-23T15:49:18Z

Hi everyone,
Here is the video after the latest development:
https://user-images.githubusercontent.com/47862474/164913355-c94f391b-2e9e-43fe-85f9-9e11ee800ca0.mp4

Please let me know your thoughts on this and provide your input.

teolemon · 2022-04-30T17:02:11Z

@bhattabhi013 Could you add some margin left and right so that the fields do not look stuck to the edges of the screen ?

bhattabhi013 · 2022-04-30T18:23:53Z

Sure @teolemon,
Here is an updated screenshot.

teolemon · 2022-04-30T18:51:37Z

The carousel can stay edge to edge, since it's intended to be scrolled

bhattabhi013 · 2022-05-03T17:46:01Z

Hi @teolemon,
Here is the updated screenshot.

teolemon · 2022-05-03T17:46:42Z

LGTM visually 👍

teolemon · 2022-05-03T17:47:13Z

@monsieurtanuki @M123-dev what about code-wise ?

monsieurtanuki

Hi @bhattabhi013!
Many comments for you, lucky you :)

packages/smooth_app/lib/pages/product/add_basic_details_page.dart

monsieurtanuki · 2022-05-03T19:09:12Z

packages/smooth_app/lib/pages/product/add_basic_details_page.dart

+            if (widget.product.barcode != null)
+              Padding(
+                padding: EdgeInsets.symmetric(horizontal: size.width * 0.05),
+                child: Column(


Not sure if adding a Column inside a ListView is a good idea. What about ListView children?

I used padding widget to add some extra padding for the textfields.

Adding a Column inside a ListView adds complexity and possible side-effects. I strongly suggest that you use either a Column or a ListView, but not both.

monsieurtanuki · 2022-05-03T19:11:27Z

packages/smooth_app/lib/pages/product/add_basic_details_page.dart

+                  ],
+                ),
+              ),
+            Row(


I don't see how you put the buttons cleanly at the bottom of the page. Here they are just after the rest, aren't they?

I used Row to horizontally align the buttons and used MainAxisAlignment.spaceAround value in mainAxisAlignment for spacing purposes. Please suggest if you have something else in your mind.

My concern is about the vertical position of the Row. Let's keep it that way.

packages/smooth_app/lib/pages/product/add_basic_details_page.dart

bhattabhi013 · 2022-05-04T18:51:22Z

Hi @bhattabhi013! Many comments for you, lucky you :)

Indeed 😁.

monsieurtanuki

Hi @bhattabhi013!
Still not convinced by the ListView / Column combination. But that's good enough I guess.

monsieurtanuki · 2022-05-06T09:34:12Z

packages/smooth_app/lib/pages/product/add_basic_details_page.dart

+            if (widget.product.barcode != null)
+              Padding(
+                padding: EdgeInsets.symmetric(horizontal: size.width * 0.05),
+                child: Column(


Adding a Column inside a ListView adds complexity and possible side-effects. I strongly suggest that you use either a Column or a ListView, but not both.

monsieurtanuki · 2022-05-06T09:44:44Z

packages/smooth_app/lib/pages/product/add_basic_details_page.dart

+                  ],
+                ),
+              ),
+            Row(


My concern is about the vertical position of the Row. Let's keep it that way.

M123-dev · 2022-05-06T16:13:57Z

We need to update the branch for it to be mergable

bhattabhi013 · 2022-05-06T18:48:09Z

Hi @M123-dev,
I'll update the branch once #1772 is merged.

M123-dev · 2022-05-06T22:24:17Z

Perfect, thanks @bhattabhi013

bhattabhi013 added 3 commits March 31, 2022 21:27

initial commit

8231b4c

ui for add basic details page

8bce90a

localization

fe59b4f

bhattabhi013 requested a review from a team as a code owner April 7, 2022 18:17

removed comments

c74164d

github-actions bot added the merge conflicts label Apr 7, 2022

monsieurtanuki mentioned this pull request Apr 9, 2022

feat: #132 - new method OpenFoodAPIClient.addProductFields openfoodfacts/openfoodfacts-dart#436

Closed

teolemon assigned bhattabhi013 Apr 9, 2022

teolemon added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users labels Apr 9, 2022

teolemon linked an issue Apr 9, 2022 that may be closed by this pull request

Add the ability to add basic details if they are not available #903

Closed

10 tasks

sent data to back-end

e06dce8

bhattabhi013 mentioned this pull request Apr 22, 2022

On product with an unknown name and/or brand, I should be able to tap on unknown name brand to enter basic details edit mode. #1428

Closed

1 task

resolved conflicts and merged with develop branch

35f9164

github-actions bot removed the merge conflicts label Apr 23, 2022

teolemon and others added 4 commits April 23, 2022 13:23

Merge branch 'develop' into addBasicDetailsPage

d3bcb40

preloaded data

deee11c

Merge branch 'develop' into addBasicDetailsPage

d3ddad7

Merge branch 'addBasicDetailsPage' of https://github.com/bhattabhi013…

08102f1

…/smooth-app into addBasicDetailsPage

github-actions bot added the merge conflicts label Apr 24, 2022

merge with develop and resolved conflicts

7832893

teolemon added the ✏️ Contribution label Apr 30, 2022

added padding

de40121

removed margin from carousel

574ba50

monsieurtanuki reviewed May 3, 2022

View reviewed changes

Merge branch 'develop' into addBasicDetailsPage

52db5db

teolemon added this to the V1 milestone May 4, 2022

teolemon linked an issue May 4, 2022 that may be closed by this pull request

On product with an unknown name and/or brand, I should be able to tap on unknown name brand to enter basic details edit mode. #1428

Closed

1 task

teolemon removed a link to an issue May 4, 2022

On product with an unknown name and/or brand, I should be able to tap on unknown name brand to enter basic details edit mode. #1428

Closed

1 task

added loader

995c3b4

github-actions bot added the merge conflicts label May 5, 2022

resolved translation conflicts

04c4425

bhattabhi013 requested a review from monsieurtanuki May 5, 2022 20:07

github-actions bot removed the merge conflicts label May 6, 2022

monsieurtanuki approved these changes May 6, 2022

View reviewed changes

github-actions bot added the merge conflicts label May 6, 2022

Merge branch 'develop' into addBasicDetailsPage

85bbc37

github-actions bot removed the merge conflicts label May 6, 2022

Merge branch 'develop' into addBasicDetailsPage

ef8d357

M123-dev merged commit 9518e2e into openfoodfacts:develop May 6, 2022

github-actions bot mentioned this pull request May 6, 2022

chore(develop): release 1.0.0 #962

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add basic details page UI #1515

feat: Add basic details page UI #1515

bhattabhi013 commented Apr 7, 2022 •

edited by teolemon

Loading

bhattabhi013 commented Apr 7, 2022

M123-dev commented Apr 7, 2022

monsieurtanuki commented Apr 7, 2022

teolemon commented Apr 9, 2022

monsieurtanuki commented Apr 9, 2022

M123-dev commented Apr 19, 2022

bhattabhi013 commented Apr 20, 2022 •

edited

Loading

codecov-commenter commented Apr 23, 2022 •

edited

Loading

bhattabhi013 commented Apr 23, 2022 •

edited

Loading

teolemon commented Apr 30, 2022

bhattabhi013 commented Apr 30, 2022

teolemon commented Apr 30, 2022

bhattabhi013 commented May 3, 2022

teolemon commented May 3, 2022

teolemon commented May 3, 2022

monsieurtanuki left a comment

monsieurtanuki May 3, 2022

bhattabhi013 May 4, 2022

monsieurtanuki May 6, 2022

monsieurtanuki May 3, 2022

bhattabhi013 May 4, 2022

monsieurtanuki May 6, 2022

bhattabhi013 commented May 4, 2022

monsieurtanuki left a comment

monsieurtanuki May 6, 2022

monsieurtanuki May 6, 2022

M123-dev commented May 6, 2022

bhattabhi013 commented May 6, 2022

M123-dev commented May 6, 2022

feat: Add basic details page UI #1515

feat: Add basic details page UI #1515

Conversation

bhattabhi013 commented Apr 7, 2022 • edited by teolemon Loading

What

Video

Fixes bug(s)

Part of

bhattabhi013 commented Apr 7, 2022

M123-dev commented Apr 7, 2022

monsieurtanuki commented Apr 7, 2022

teolemon commented Apr 9, 2022

monsieurtanuki commented Apr 9, 2022

M123-dev commented Apr 19, 2022

bhattabhi013 commented Apr 20, 2022 • edited Loading

codecov-commenter commented Apr 23, 2022 • edited Loading

Codecov Report

bhattabhi013 commented Apr 23, 2022 • edited Loading

teolemon commented Apr 30, 2022

bhattabhi013 commented Apr 30, 2022

teolemon commented Apr 30, 2022

bhattabhi013 commented May 3, 2022

teolemon commented May 3, 2022

teolemon commented May 3, 2022

monsieurtanuki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhattabhi013 commented May 4, 2022

monsieurtanuki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

M123-dev commented May 6, 2022

bhattabhi013 commented May 6, 2022

M123-dev commented May 6, 2022

bhattabhi013 commented Apr 7, 2022 •

edited by teolemon

Loading

bhattabhi013 commented Apr 20, 2022 •

edited

Loading

codecov-commenter commented Apr 23, 2022 •

edited

Loading

bhattabhi013 commented Apr 23, 2022 •

edited

Loading