feat: #960 - changed the attribute/importance preference display. #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… display. Impacted files: * `attribute_button.dart`: changed the whole display. * `design_constants.dart`: added a constant for the default icon size. * `product_preferences.dart`: added the downgrading of "very important" to "important". * `pubspec.lock`: wtf
Impacted files: * `attribute_button.dart`: adjustments in order to pass the goldens test. * `design_constants.dart`: added a constant for the minimum target size (according to goldens). * `user_preferences_page-blue-dark.png`: impacted by new display. * `user_preferences_page-blue-light.png`: impacted by new display. * `user_preferences_page-brown-dark.png`: impacted by new display. * `user_preferences_page-brown-light.png`: impacted by new display. * `user_preferences_page-green-dark.png`: impacted by new display. * `user_preferences_page-green-light.png`: impacted by new display.
Codecov Report
@@ Coverage Diff @@
## develop #1590 +/- ##
==========================================
+ Coverage 8.86% 8.99% +0.13%
==========================================
Files 161 161
Lines 6623 6657 +34
==========================================
+ Hits 587 599 +12
- Misses 6036 6058 +22
Continue to review full report at Codecov.
|
|
@stephanegigandet ping |
|
@stephanegigandet ping |
|
@stephanegigandet ping |
stephanegigandet
approved these changes
May 4, 2022
There was a problem hiding this comment.
Hi @monsieurtanuki ,
Sorry I missed the notifications.
It looks very good to me, thank you very much!
|
Thank you @stephanegigandet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
attribute_button.dart: changed the whole display.design_constants.dart: added a constant for the default icon size.product_preferences.dart: removed the downgrading of "very important" to "important".pubspec.lock: wtfWhat
Screenshot
[Edited screenshot after goldens fixes]
Part of