Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Button ingredient extraction appear after upload an image. Issue: #1624 #1719

Merged
merged 6 commits into from
May 3, 2022
Merged

feat: Button ingredient extraction appear after upload an image. Issue: #1624 #1719

merged 6 commits into from
May 3, 2022

Conversation

Pualoo
Copy link
Contributor

@Pualoo Pualoo commented Apr 29, 2022

What

Screenshot

smoth_app_example_.1624.mp4

@Pualoo Pualoo requested a review from a team as a code owner April 29, 2022 21:20
@codecov-commenter
Copy link

Codecov Report

Merging #1719 (cb52f76) into develop (2ea0da3) will decrease coverage by 0.57%.
The diff coverage is 0.68%.

@@            Coverage Diff             @@
##           develop   #1719      +/-   ##
==========================================
- Coverage     8.86%   8.28%   -0.58%     
==========================================
  Files          161     165       +4     
  Lines         6623    7131     +508     
==========================================
+ Hits           587     591       +4     
- Misses        6036    6540     +504     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd10bbb...cb52f76. Read the comment docs.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyy @Pualoo, looks really good, thanks and sorry that it took a little longer with the review

@M123-dev M123-dev merged commit 4777adb into openfoodfacts:develop May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

(Product Addition) A button to open ingredient extraction should appear after upload of the ingredients photo
3 participants