Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added nutrition input to product addition flow #1751

Merged
merged 3 commits into from
May 8, 2022

Conversation

PrimaelQuemerais
Copy link
Member

What

  • Added direct link to the nutrition_page_loaded from the add_new_product_page to allow manual input of nutritional values

Screenshot

Fixes bug(s)

Part of

@PrimaelQuemerais PrimaelQuemerais requested a review from a team as a code owner May 5, 2022 14:38
@teolemon teolemon linked an issue May 5, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #1751 (a29add3) into develop (2ea0da3) will decrease coverage by 0.53%.
The diff coverage is 0.60%.

@@            Coverage Diff             @@
##           develop   #1751      +/-   ##
==========================================
- Coverage     8.86%   8.32%   -0.54%     
==========================================
  Files          161     167       +6     
  Lines         6623    7263     +640     
==========================================
+ Hits           587     605      +18     
- Misses        6036    6658     +622     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e050800...a29add3. Read the comment docs.

@teolemon
Copy link
Member

teolemon commented May 6, 2022

Neat 👍

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more step on the Road to Scores 👍

@teolemon teolemon added the Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. label May 6, 2022
@teolemon teolemon added this to the V1 milestone May 6, 2022
@teolemon
Copy link
Member

teolemon commented May 8, 2022

merging, thank you very much @PrimaelQuemerais

@teolemon teolemon merged commit 4036111 into openfoodfacts:develop May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Development

Successfully merging this pull request may close these issues.

Insert nutrition input within the new product addition flow
4 participants