Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly managed state for country selector #1758

Merged
merged 1 commit into from
May 5, 2022

Conversation

AshAman999
Copy link
Member

What

  • Country selector works properly now

Screenshot

Record_2022-05-05-23-50-24_cc729dbb1ea2c751a543590b5da9708c.mp4

Fixes bug(s)

Part of

@AshAman999 AshAman999 requested a review from a team as a code owner May 5, 2022 18:24
@codecov-commenter
Copy link

Codecov Report

Merging #1758 (2d19cf2) into develop (2ea0da3) will decrease coverage by 0.51%.
The diff coverage is 0.60%.

@@            Coverage Diff             @@
##           develop   #1758      +/-   ##
==========================================
- Coverage     8.86%   8.34%   -0.52%     
==========================================
  Files          161     167       +6     
  Lines         6623    7247     +624     
==========================================
+ Hits           587     605      +18     
- Misses        6036    6642     +606     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b9bc5...2d19cf2. Read the comment docs.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the quick fix @AshAman999 🎉

@M123-dev M123-dev merged commit e8a336e into openfoodfacts:develop May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abnormal state in country selector
3 participants